From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Pavel Machek <pavel@denx.de>, Thor Thayer <tthayer.linux@gmail.com>
Cc: Thor Thayer <tthayer@altera.com>,
Dinh Nguyen <dinguyen@altera.com>,
Steffen Trumtrar <s.trumtrar@pengutronix.de>,
linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org,
socketcan@hartkopp.net, wg@grandegger.com
Subject: Re: [PATCH 2/2] Add 32-bit accesses
Date: Mon, 05 May 2014 14:40:05 +0200 [thread overview]
Message-ID: <536786A5.7070002@pengutronix.de> (raw)
In-Reply-To: <20140505120801.GA16461@amd.pavel.ucw.cz>
On 05/05/2014 02:08 PM, Pavel Machek wrote:
>
> Add helpers for 32-bit accesses and replace open-coded 32-bit access
> with calls to helpers.
In general looks good, but please add the modifications from the
platform file, where you add the 32 callbacks to this patch. Please
don't forget to modify the pci driver, too.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
next prev parent reply other threads:[~2014-05-05 12:40 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1396422700-3962-1-git-send-email-s.trumtrar@pengutronix.de>
[not found] ` <1396422700-3962-4-git-send-email-s.trumtrar@pengutronix.de>
[not found] ` <20140404102815.GA9242@amd.pavel.ucw.cz>
2014-04-25 19:53 ` can problems on socfpga [was Re: [PATCH v2 4/6] ARM: socfpga: dts: add can0+1] Pavel Machek
2014-04-25 20:24 ` Dinh Nguyen
2014-04-25 21:31 ` Thor Thayer
2014-04-26 8:57 ` Pavel Machek
2014-04-26 9:16 ` Pavel Machek
2014-04-26 9:36 ` Pavel Machek
2014-04-26 20:31 ` Pavel Machek
2014-04-26 20:51 ` Oliver Hartkopp
2014-04-26 22:37 ` Marc Kleine-Budde
2014-04-27 12:25 ` [patch] Fix CAN on socfpga, for net/master Pavel Machek
2014-04-28 20:20 ` Thor Thayer
2014-04-28 21:15 ` Pavel Machek
2014-04-28 23:37 ` T Thayer
[not found] ` <CAF03EBd19PC5RAsLR6-dMPF2x3XRf9X4bFPgX2kRdCYWUQBYcA@mail.gmail.com>
2014-04-30 21:53 ` Pavel Machek
2014-05-01 13:15 ` Thor Thayer
2014-05-02 8:48 ` [PATCHv2] " Pavel Machek
2014-05-02 12:27 ` Marc Kleine-Budde
2014-05-05 12:07 ` Pavel Machek
2014-05-13 12:07 ` Pavel Machek
2014-05-05 12:08 ` [PATCH 2/2] Add 32-bit accesses Pavel Machek
2014-05-05 12:40 ` Marc Kleine-Budde [this message]
2014-05-06 13:57 ` [PATCHv3] C_CAN: " Pavel Machek
2014-05-12 15:47 ` Marc Kleine-Budde
2014-05-13 11:29 ` Pavel Machek
2014-05-13 13:09 ` [PATCHv3] C_CAN: hwinit support for non-TI devices Pavel Machek
2014-05-13 13:36 ` Marc Kleine-Budde
2014-05-13 15:08 ` Pavel Machek
2014-05-13 15:18 ` Marc Kleine-Budde
2014-05-05 12:08 ` [PATCH 1/2] " Pavel Machek
2014-05-05 12:21 ` Marc Kleine-Budde
2014-05-05 12:22 ` Marc Kleine-Budde
2014-05-05 12:58 ` Pavel Machek
2014-05-05 13:00 ` Marc Kleine-Budde
2014-05-05 13:00 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536786A5.7070002@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=dinguyen@altera.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=pavel@denx.de \
--cc=s.trumtrar@pengutronix.de \
--cc=socketcan@hartkopp.net \
--cc=tthayer.linux@gmail.com \
--cc=tthayer@altera.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).