Re: [Gitorious] Activity: prabhakar requested a merge of prab...

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 2139 bytes --]

On 06/24/2014 01:06 PM, Prabhakar Lad wrote:
> Hi
> 
> On Mon, Jun 23, 2014 at 5:46 PM, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
>> On 06/23/2014 06:30 PM, Oliver Hartkopp wrote:
>>> On 23.06.2014 18:22, Marc Kleine-Budde wrote:
>>>> On 06/23/2014 06:12 PM, Oliver Hartkopp wrote:
>>>>> Hi Prabhakar,
>>>>>
>>>>> thanks for your patch.
>>>>>
>>>>> Can you please send it with git send-email to the mailing list for a review?
>>>>>
>>>>> Additionally:
>>>>>
>>>>> Does this patch introduce any backward compatibility restrictions (e.g. you
>>>>> need at least the includes from 2.6.14+ to build candump ...).
>>>>
>>>> When was CAN support added to the linux kernel? :)
>>>
>>> I know that you would detect this joke ;-)
>>> Btw. I backported SocketCAN to 2.6.13 - so my question is not totally
>>> brain-damaged when talking about the can-utils which are not sticking to a
>>> specific kernel version.
>>
>> I was assuming that there was a certain seriousness in your statement :D
>>
>> Do you mean the inclusion of "sched.h"? I think this comes from the
>> glibc. However, we can add autotool support to detect this.
>>
>>>>> You only provide to configure a value for SCHED_RR.
>>>>> Does it make sense to provide other scheduling policies too?
>>>>
>>>> I would use chrt to start the tool, if I need non standard scheduling
>>>> policies.
>>>
>>> But then you would like to specifiy the scheduling policy??
>>
>> You can use chrt to start another program with different scheduling
>> policies, it's like nice, but with more functionality. See man page of
>> chrt for more information.
>>
> What do you suggest to go with the patch or just use chrt ?

From my point of view candump is a debugging tool anyways, using it
together with chrt makes sense. Do you have a good argument why not to
use chrt?

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]