[PATCH] do not use --symlink for autoreconf

[PATCH] do not use --symlink for autoreconf

[Andre Naujoks]

When packaging the can-utils, I understand, that the generation step for
autoconf should be done beforehand. However using the --symlink option in the
autoreconf step installs links instead of the actual files, which leads to a
build failure when trying to build on another host with different autotools
installed.

Signed-off-by: Andre Naujoks <nautsch2@gmail.com>
---
 autogen.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/autogen.sh b/autogen.sh
index 29db9c9..6d1c20a 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -17,6 +17,6 @@ banner() {
 
 banner "autoreconf"
 
-autoreconf --force --install --symlink -Wall || exit $?
+autoreconf --force --install -Wall || exit $?
 
 banner "Finished"
-- 
2.0.1

Re: [PATCH] do not use --symlink for autoreconf

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 816 bytes --]

On 07/02/2014 02:12 PM, Andre Naujoks wrote:
> When packaging the can-utils, I understand, that the generation step for
> autoconf should be done beforehand. However using the --symlink option in the
> autoreconf step installs links instead of the actual files, which leads to a
> build failure when trying to build on another host with different autotools
> installed.
> 
> Signed-off-by: Andre Naujoks <nautsch2@gmail.com>

How do you package the can-utils? The usual steps are:

./autogen.sh
./configure
make dist

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]

Re: [PATCH] do not use --symlink for autoreconf

[Andre Naujoks]

On 02.07.2014 14:18, Marc Kleine-Budde wrote:
> On 07/02/2014 02:12 PM, Andre Naujoks wrote:
>> When packaging the can-utils, I understand, that the generation
>> step for autoconf should be done beforehand. However using the
>> --symlink option in the autoreconf step installs links instead of
>> the actual files, which leads to a build failure when trying to
>> build on another host with different autotools installed.
>> 
>> Signed-off-by: Andre Naujoks <nautsch2@gmail.com>
> 
> How do you package the can-utils? The usual steps are:
> 
> ./autogen.sh ./configure make dist

with git archive. Something like

git archive --prefix=can-utils-`git describe --always --dirty`/ -o
can-utils-`git describe --always --dirty`.tar.gz HEAD

I was not aware of the dist target. Why do I have to configure before
creating the dist? Isn't the configure step just for adaptations for
the build-host and target?

Andre

> 
> Marc
> 

Re: [PATCH] do not use --symlink for autoreconf

[Andre Naujoks]

On 02.07.2014 14:34, Andre Naujoks wrote:
> On 02.07.2014 14:18, Marc Kleine-Budde wrote:
>> On 07/02/2014 02:12 PM, Andre Naujoks wrote:
>>> When packaging the can-utils, I understand, that the generation
>>> step for autoconf should be done beforehand. However using the
>>> --symlink option in the autoreconf step installs links instead of
>>> the actual files, which leads to a build failure when trying to
>>> build on another host with different autotools installed.
>>>
>>> Signed-off-by: Andre Naujoks <nautsch2@gmail.com>
>>
>> How do you package the can-utils? The usual steps are:
>>
>> ./autogen.sh ./configure make dist
> 
> with git archive. Something like
> 
> git archive --prefix=can-utils-`git describe --always --dirty`/ -o
> can-utils-`git describe --always --dirty`.tar.gz HEAD

... after which I unpack, autogen.sh and repack. Which is probably not
the sanest way of doing this, but should work.

> 
> I was not aware of the dist target. Why do I have to configure before
> creating the dist? Isn't the configure step just for adaptations for
> the build-host and target?
> 
> Andre
> 
>>
>> Marc
>>
> 

Re: [PATCH] do not use --symlink for autoreconf

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 1700 bytes --]

On 07/02/2014 02:34 PM, Andre Naujoks wrote:
> On 02.07.2014 14:18, Marc Kleine-Budde wrote:
>> On 07/02/2014 02:12 PM, Andre Naujoks wrote:
>>> When packaging the can-utils, I understand, that the generation
>>> step for autoconf should be done beforehand. However using the
>>> --symlink option in the autoreconf step installs links instead of
>>> the actual files, which leads to a build failure when trying to
>>> build on another host with different autotools installed.
>>>
>>> Signed-off-by: Andre Naujoks <nautsch2@gmail.com>
>>
>> How do you package the can-utils? The usual steps are:
>>
>> ./autogen.sh ./configure make dist
> 
> with git archive. Something like
> 
> git archive --prefix=can-utils-`git describe --always --dirty`/ -o
> can-utils-`git describe --always --dirty`.tar.gz HEAD

AFAIK: git will not archive any files that are not in git, thus no files
generated by autoconf.sh.

> I was not aware of the dist target. Why do I have to configure before
> creating the dist? Isn't the configure step just for adaptations for
> the build-host and target?

Usually you're right, but wihtout the autogen.sh && ./configure run,
there are no makefiles that contian the code for make dist. Note: the
can-utils package hold a handcraftet Makefile for the people who don't
like autotools. And autotools will generate GNUmakefile, which has a
higher priority for gnu make.

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]

Re: [PATCH] do not use --symlink for autoreconf

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 1348 bytes --]

On 07/02/2014 02:41 PM, Andre Naujoks wrote:
> On 02.07.2014 14:34, Andre Naujoks wrote:
>> On 02.07.2014 14:18, Marc Kleine-Budde wrote:
>>> On 07/02/2014 02:12 PM, Andre Naujoks wrote:
>>>> When packaging the can-utils, I understand, that the generation
>>>> step for autoconf should be done beforehand. However using the
>>>> --symlink option in the autoreconf step installs links instead of
>>>> the actual files, which leads to a build failure when trying to
>>>> build on another host with different autotools installed.
>>>>
>>>> Signed-off-by: Andre Naujoks <nautsch2@gmail.com>
>>>
>>> How do you package the can-utils? The usual steps are:
>>>
>>> ./autogen.sh ./configure make dist
>>
>> with git archive. Something like
>>
>> git archive --prefix=can-utils-`git describe --always --dirty`/ -o
>> can-utils-`git describe --always --dirty`.tar.gz HEAD
> 
> ... after which I unpack, autogen.sh and repack. Which is probably not
> the sanest way of doing this, but should work.

This is why you get the problems with the links....

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]

Re: [PATCH] do not use --symlink for autoreconf

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 2215 bytes --]

On 07/02/2014 02:58 PM, Marc Kleine-Budde wrote:
> On 07/02/2014 02:41 PM, Andre Naujoks wrote:
>> On 02.07.2014 14:34, Andre Naujoks wrote:
>>> On 02.07.2014 14:18, Marc Kleine-Budde wrote:
>>>> On 07/02/2014 02:12 PM, Andre Naujoks wrote:
>>>>> When packaging the can-utils, I understand, that the generation
>>>>> step for autoconf should be done beforehand. However using the
>>>>> --symlink option in the autoreconf step installs links instead of
>>>>> the actual files, which leads to a build failure when trying to
>>>>> build on another host with different autotools installed.
>>>>>
>>>>> Signed-off-by: Andre Naujoks <nautsch2@gmail.com>
>>>>
>>>> How do you package the can-utils? The usual steps are:
>>>>
>>>> ./autogen.sh ./configure make dist
>>>
>>> with git archive. Something like
>>>
>>> git archive --prefix=can-utils-`git describe --always --dirty`/ -o
>>> can-utils-`git describe --always --dirty`.tar.gz HEAD
>>
>> ... after which I unpack, autogen.sh and repack. Which is probably not
>> the sanest way of doing this, but should work.
> 
> This is why you get the problems with the links....

Try something like this instead (untested, though):

project=can-utils-`git describe --always --dirty`
git archive --prefix=$project/ -o $project.tar HEAD
tar xf $project.tar
cd $project
./autogen.sh
cd ..
tar -rhf $project.tar \
        $project/GNUmakefile.in
        $project/aclocal.m4
        $project/autom4te.cache/
        $project/config/autoconf/
        $project/config/m4/libtool.m4
        $project/config/m4/ltoptions.m4
        $project/config/m4/ltsugar.m4
        $project/config/m4/ltversion.m4
        $project/config/m4/lt~obsolete.m4
        $project/configure

From tar's man-page:
     -r, --append
           append files to the end of an archive
     -h, --dereference
           follow symlinks; archive and dump the files they point to

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]

Re: [PATCH] do not use --symlink for autoreconf

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 2170 bytes --]

On 07/02/2014 03:06 PM, Marc Kleine-Budde wrote:
> On 07/02/2014 02:58 PM, Marc Kleine-Budde wrote:
>> On 07/02/2014 02:41 PM, Andre Naujoks wrote:
>>> On 02.07.2014 14:34, Andre Naujoks wrote:
>>>> On 02.07.2014 14:18, Marc Kleine-Budde wrote:
>>>>> On 07/02/2014 02:12 PM, Andre Naujoks wrote:
>>>>>> When packaging the can-utils, I understand, that the generation
>>>>>> step for autoconf should be done beforehand. However using the
>>>>>> --symlink option in the autoreconf step installs links instead of
>>>>>> the actual files, which leads to a build failure when trying to
>>>>>> build on another host with different autotools installed.
>>>>>>
>>>>>> Signed-off-by: Andre Naujoks <nautsch2@gmail.com>
>>>>>
>>>>> How do you package the can-utils? The usual steps are:
>>>>>
>>>>> ./autogen.sh ./configure make dist
>>>>
>>>> with git archive. Something like
>>>>
>>>> git archive --prefix=can-utils-`git describe --always --dirty`/ -o
>>>> can-utils-`git describe --always --dirty`.tar.gz HEAD
>>>
>>> ... after which I unpack, autogen.sh and repack. Which is probably not
>>> the sanest way of doing this, but should work.
>>
>> This is why you get the problems with the links....
> 
> Try something like this instead (untested, though):
> 
> project=can-utils-`git describe --always --dirty`
> git archive --prefix=$project/ -o $project.tar HEAD
> tar xf $project.tar
> cd $project
> ./autogen.sh
> cd ..
> tar -rhf $project.tar \
>         $project/GNUmakefile.in
>         $project/aclocal.m4
>         $project/autom4te.cache/
>         $project/config/autoconf/
>         $project/config/m4/libtool.m4
>         $project/config/m4/ltoptions.m4
>         $project/config/m4/ltsugar.m4
>         $project/config/m4/ltversion.m4
>         $project/config/m4/lt~obsolete.m4
>         $project/configure

gzip -9 $project.tar

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]

Re: [PATCH] do not use --symlink for autoreconf

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 1958 bytes --]

On 07/02/2014 03:06 PM, Marc Kleine-Budde wrote:
> On 07/02/2014 02:58 PM, Marc Kleine-Budde wrote:
>> On 07/02/2014 02:41 PM, Andre Naujoks wrote:
>>> On 02.07.2014 14:34, Andre Naujoks wrote:
>>>> On 02.07.2014 14:18, Marc Kleine-Budde wrote:
>>>>> On 07/02/2014 02:12 PM, Andre Naujoks wrote:
>>>>>> When packaging the can-utils, I understand, that the generation
>>>>>> step for autoconf should be done beforehand. However using the
>>>>>> --symlink option in the autoreconf step installs links instead of
>>>>>> the actual files, which leads to a build failure when trying to
>>>>>> build on another host with different autotools installed.
>>>>>>
>>>>>> Signed-off-by: Andre Naujoks <nautsch2@gmail.com>
>>>>>
>>>>> How do you package the can-utils? The usual steps are:
>>>>>
>>>>> ./autogen.sh ./configure make dist
>>>>
>>>> with git archive. Something like
>>>>
>>>> git archive --prefix=can-utils-`git describe --always --dirty`/ -o
>>>> can-utils-`git describe --always --dirty`.tar.gz HEAD
>>>
>>> ... after which I unpack, autogen.sh and repack. Which is probably not
>>> the sanest way of doing this, but should work.
>>
>> This is why you get the problems with the links....
> 
> Try something like this instead (untested, though):
> 
> project=can-utils-`git describe --always --dirty`
> git archive --prefix=$project/ -o $project.tar HEAD
> tar xf $project.tar
> cd $project
> ./autogen.sh
> cd ..
> tar -rhf $project.tar \
>         $project/GNUmakefile.in
>         $project/aclocal.m4
>         $project/autom4te.cache/
          ^^^^^^^^^^^^^^^^^^^^^^^^

Doh! You don't want to package this. Copy/Paste error.

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]

Re: [PATCH] do not use --symlink for autoreconf

[Andre Naujoks]

On 02.07.2014 15:08, Marc Kleine-Budde wrote:
> On 07/02/2014 03:06 PM, Marc Kleine-Budde wrote:
>> On 07/02/2014 02:58 PM, Marc Kleine-Budde wrote:
>>> On 07/02/2014 02:41 PM, Andre Naujoks wrote:
>>>> On 02.07.2014 14:34, Andre Naujoks wrote:
>>>>> On 02.07.2014 14:18, Marc Kleine-Budde wrote:
>>>>>> On 07/02/2014 02:12 PM, Andre Naujoks wrote:
>>>>>>> When packaging the can-utils, I understand, that the
>>>>>>> generation step for autoconf should be done beforehand.
>>>>>>> However using the --symlink option in the autoreconf
>>>>>>> step installs links instead of the actual files, which
>>>>>>> leads to a build failure when trying to build on
>>>>>>> another host with different autotools installed.
>>>>>>> 
>>>>>>> Signed-off-by: Andre Naujoks <nautsch2@gmail.com>
>>>>>> 
>>>>>> How do you package the can-utils? The usual steps are:
>>>>>> 
>>>>>> ./autogen.sh ./configure make dist
>>>>> 
>>>>> with git archive. Something like
>>>>> 
>>>>> git archive --prefix=can-utils-`git describe --always
>>>>> --dirty`/ -o can-utils-`git describe --always
>>>>> --dirty`.tar.gz HEAD
>>>> 
>>>> ... after which I unpack, autogen.sh and repack. Which is
>>>> probably not the sanest way of doing this, but should work.
>>> 
>>> This is why you get the problems with the links....
>> 
>> Try something like this instead (untested, though):
>> 
>> project=can-utils-`git describe --always --dirty` git archive
>> --prefix=$project/ -o $project.tar HEAD tar xf $project.tar cd
>> $project ./autogen.sh cd .. tar -rhf $project.tar \ 
>> $project/GNUmakefile.in $project/aclocal.m4 
>> $project/autom4te.cache/
> ^^^^^^^^^^^^^^^^^^^^^^^^

This is all nice and all, and I appreciate it, but why is the
--symlink parameter there in the first place? I see no benefit from
using it. It just makes things harder if you do it "the normal way".

Another thing is, that you need a host with all build dependencies
resolved (i.e. configure completes) just to generate an unbuild
package. This might not be a problem now (or ever), but why put in
such a pitfall, when it is not needed?

Andre

> 
> Doh! You don't want to package this. Copy/Paste error.
> 
> Marc
> 

Re: [PATCH] do not use --symlink for autoreconf

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 2611 bytes --]

On 07/02/2014 03:47 PM, Andre Naujoks wrote:
> On 02.07.2014 15:08, Marc Kleine-Budde wrote:
>> On 07/02/2014 03:06 PM, Marc Kleine-Budde wrote:
>>> On 07/02/2014 02:58 PM, Marc Kleine-Budde wrote:
>>>> On 07/02/2014 02:41 PM, Andre Naujoks wrote:
>>>>> On 02.07.2014 14:34, Andre Naujoks wrote:
>>>>>> On 02.07.2014 14:18, Marc Kleine-Budde wrote:
>>>>>>> On 07/02/2014 02:12 PM, Andre Naujoks wrote:
>>>>>>>> When packaging the can-utils, I understand, that the
>>>>>>>> generation step for autoconf should be done beforehand.
>>>>>>>> However using the --symlink option in the autoreconf
>>>>>>>> step installs links instead of the actual files, which
>>>>>>>> leads to a build failure when trying to build on
>>>>>>>> another host with different autotools installed.
>>>>>>>>
>>>>>>>> Signed-off-by: Andre Naujoks <nautsch2@gmail.com>
>>>>>>>
>>>>>>> How do you package the can-utils? The usual steps are:
>>>>>>>
>>>>>>> ./autogen.sh ./configure make dist
>>>>>>
>>>>>> with git archive. Something like
>>>>>>
>>>>>> git archive --prefix=can-utils-`git describe --always
>>>>>> --dirty`/ -o can-utils-`git describe --always
>>>>>> --dirty`.tar.gz HEAD
>>>>>
>>>>> ... after which I unpack, autogen.sh and repack. Which is
>>>>> probably not the sanest way of doing this, but should work.
>>>>
>>>> This is why you get the problems with the links....
>>>
>>> Try something like this instead (untested, though):
>>>
>>> project=can-utils-`git describe --always --dirty` git archive
>>> --prefix=$project/ -o $project.tar HEAD tar xf $project.tar cd
>>> $project ./autogen.sh cd .. tar -rhf $project.tar \ 
>>> $project/GNUmakefile.in $project/aclocal.m4 
>>> $project/autom4te.cache/
>> ^^^^^^^^^^^^^^^^^^^^^^^^
> 
> This is all nice and all, and I appreciate it, but why is the
> --symlink parameter there in the first place? I see no benefit from
> using it. It just makes things harder if you do it "the normal way".

Yes, I think the autotools/git interaction can be improved.

> Another thing is, that you need a host with all build dependencies
> resolved (i.e. configure completes) just to generate an unbuild
> package. This might not be a problem now (or ever), but why put in
> such a pitfall, when it is not needed?

For now I've applied your patch.

Thanks,
Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]

Re: [PATCH] do not use --symlink for autoreconf

[Andre Naujoks]

On 02.07.2014 16:05, Marc Kleine-Budde wrote:
> On 07/02/2014 03:47 PM, Andre Naujoks wrote:
>> On 02.07.2014 15:08, Marc Kleine-Budde wrote:
>>> On 07/02/2014 03:06 PM, Marc Kleine-Budde wrote:
>>>> On 07/02/2014 02:58 PM, Marc Kleine-Budde wrote:
>>>>> On 07/02/2014 02:41 PM, Andre Naujoks wrote:
>>>>>> On 02.07.2014 14:34, Andre Naujoks wrote:
>>>>>>> On 02.07.2014 14:18, Marc Kleine-Budde wrote:
>>>>>>>> On 07/02/2014 02:12 PM, Andre Naujoks wrote:
>>>>>>>>> When packaging the can-utils, I understand, that
>>>>>>>>> the generation step for autoconf should be done
>>>>>>>>> beforehand. However using the --symlink option in
>>>>>>>>> the autoreconf step installs links instead of the
>>>>>>>>> actual files, which leads to a build failure when
>>>>>>>>> trying to build on another host with different
>>>>>>>>> autotools installed.
>>>>>>>>> 
>>>>>>>>> Signed-off-by: Andre Naujoks <nautsch2@gmail.com>
>>>>>>>> 
>>>>>>>> How do you package the can-utils? The usual steps
>>>>>>>> are:
>>>>>>>> 
>>>>>>>> ./autogen.sh ./configure make dist
>>>>>>> 
>>>>>>> with git archive. Something like
>>>>>>> 
>>>>>>> git archive --prefix=can-utils-`git describe --always 
>>>>>>> --dirty`/ -o can-utils-`git describe --always 
>>>>>>> --dirty`.tar.gz HEAD
>>>>>> 
>>>>>> ... after which I unpack, autogen.sh and repack. Which
>>>>>> is probably not the sanest way of doing this, but should
>>>>>> work.
>>>>> 
>>>>> This is why you get the problems with the links....
>>>> 
>>>> Try something like this instead (untested, though):
>>>> 
>>>> project=can-utils-`git describe --always --dirty` git
>>>> archive --prefix=$project/ -o $project.tar HEAD tar xf
>>>> $project.tar cd $project ./autogen.sh cd .. tar -rhf
>>>> $project.tar \ $project/GNUmakefile.in $project/aclocal.m4 
>>>> $project/autom4te.cache/
>>> ^^^^^^^^^^^^^^^^^^^^^^^^
>> 
>> This is all nice and all, and I appreciate it, but why is the 
>> --symlink parameter there in the first place? I see no benefit
>> from using it. It just makes things harder if you do it "the
>> normal way".
> 
> Yes, I think the autotools/git interaction can be improved.
> 
>> Another thing is, that you need a host with all build
>> dependencies resolved (i.e. configure completes) just to generate
>> an unbuild package. This might not be a problem now (or ever),
>> but why put in such a pitfall, when it is not needed?
> 
> For now I've applied your patch.

Great! Thank you. :-)

> 
> Thanks, Marc
>