From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Andre Naujoks <nautsch2@gmail.com>, linux-can@vger.kernel.org
Cc: socketcan@hartkopp.net
Subject: Re: [PATCH] do not use --symlink for autoreconf
Date: Wed, 02 Jul 2014 15:08:37 +0200 [thread overview]
Message-ID: <53B40455.80202@pengutronix.de> (raw)
In-Reply-To: <53B403D5.9070406@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1958 bytes --]
On 07/02/2014 03:06 PM, Marc Kleine-Budde wrote:
> On 07/02/2014 02:58 PM, Marc Kleine-Budde wrote:
>> On 07/02/2014 02:41 PM, Andre Naujoks wrote:
>>> On 02.07.2014 14:34, Andre Naujoks wrote:
>>>> On 02.07.2014 14:18, Marc Kleine-Budde wrote:
>>>>> On 07/02/2014 02:12 PM, Andre Naujoks wrote:
>>>>>> When packaging the can-utils, I understand, that the generation
>>>>>> step for autoconf should be done beforehand. However using the
>>>>>> --symlink option in the autoreconf step installs links instead of
>>>>>> the actual files, which leads to a build failure when trying to
>>>>>> build on another host with different autotools installed.
>>>>>>
>>>>>> Signed-off-by: Andre Naujoks <nautsch2@gmail.com>
>>>>>
>>>>> How do you package the can-utils? The usual steps are:
>>>>>
>>>>> ./autogen.sh ./configure make dist
>>>>
>>>> with git archive. Something like
>>>>
>>>> git archive --prefix=can-utils-`git describe --always --dirty`/ -o
>>>> can-utils-`git describe --always --dirty`.tar.gz HEAD
>>>
>>> ... after which I unpack, autogen.sh and repack. Which is probably not
>>> the sanest way of doing this, but should work.
>>
>> This is why you get the problems with the links....
>
> Try something like this instead (untested, though):
>
> project=can-utils-`git describe --always --dirty`
> git archive --prefix=$project/ -o $project.tar HEAD
> tar xf $project.tar
> cd $project
> ./autogen.sh
> cd ..
> tar -rhf $project.tar \
> $project/GNUmakefile.in
> $project/aclocal.m4
> $project/autom4te.cache/
^^^^^^^^^^^^^^^^^^^^^^^^
Doh! You don't want to package this. Copy/Paste error.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]
next prev parent reply other threads:[~2014-07-02 13:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 12:12 [PATCH] do not use --symlink for autoreconf Andre Naujoks
2014-07-02 12:18 ` Marc Kleine-Budde
2014-07-02 12:34 ` Andre Naujoks
2014-07-02 12:41 ` Andre Naujoks
2014-07-02 12:58 ` Marc Kleine-Budde
2014-07-02 13:06 ` Marc Kleine-Budde
2014-07-02 13:07 ` Marc Kleine-Budde
2014-07-02 13:08 ` Marc Kleine-Budde [this message]
2014-07-02 13:47 ` Andre Naujoks
2014-07-02 14:05 ` Marc Kleine-Budde
2014-07-02 14:09 ` Andre Naujoks
2014-07-02 12:57 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B40455.80202@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=nautsch2@gmail.com \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).