Re: [PATCH 3/4] can: netlink: Add CAN_CTRLMODE_PRESUME_ACK flag

[Oliver Hartkopp <socketcan@hartkopp.net>]

Hello Marc and Wolfgang,

what do you think about this extension.

 From my side the patchset makes sense.

Regards,
Oliver

On 09.07.2014 15:31, Nikita Edward Baruzdin wrote:
> Most CAN controllers have a support for ignoring ACK absence. Some of
> them refer to this feature as a self test mode (e. g. SJA1000) and some
> include it as a part of a loopback mode (e. g. MCP2510).
>
> Setting the introduced flag via netlink should make CAN controller
> perform a successful transmission, even if there is no acknowledgement
> (dominant ACK bit) received.
>
> Signed-off-by: Nikita Edward Baruzdin <nebaruzdin@gmail.com>
> ---
>   include/uapi/linux/can/netlink.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/can/netlink.h b/include/uapi/linux/can/netlink.h
> index 3bbf5c7..3e4323a 100644
> --- a/include/uapi/linux/can/netlink.h
> +++ b/include/uapi/linux/can/netlink.h
> @@ -97,6 +97,7 @@ struct can_ctrlmode {
>   #define CAN_CTRLMODE_ONE_SHOT		0x08	/* One-Shot mode */
>   #define CAN_CTRLMODE_BERR_REPORTING	0x10	/* Bus-error reporting */
>   #define CAN_CTRLMODE_FD			0x20	/* CAN FD mode */
> +#define CAN_CTRLMODE_PRESUME_ACK	0x40	/* Ignore missing CAN ACKs */
>
>   /*
>    * CAN device statistics
>