From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Austin Schuh <austin@peloton-tech.com>,
Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org
Subject: Re: skbuff panic
Date: Fri, 11 Jul 2014 09:27:19 -0400 [thread overview]
Message-ID: <53BFE637.2030905@hartkopp.net> (raw)
In-Reply-To: <CANGgnMY4+PTnkd9CBUSS4EM6ZjP9r1wp8JYDJ4fYv+P1Qg6-vg@mail.gmail.com>
Thanks for testing, Austin!
I'll cook a patch for stable to add these settings.
Even if we do not know why someone requests obviously all netdev skbs and
treats them to be Ethernet/IP packets we should fix it in our code.
If we fix it somewhere else it will last one year until some of the
is-there-anything-else-than-ethernet-networking guys will break it again. ;-)
Best regards,
Oliver
On 10.07.2014 13:37, Austin Schuh wrote:
> On Wed, Jul 9, 2014 at 5:07 PM, Austin Schuh <austin@peloton-tech.com> wrote:
>> With Oliver's patch, I'm able to get to 60 reboots and counting, so it
>> looks like that was the problem. I'll leave it rebooting over night
>> to be sure.
>
> The machine survived 216 reboots with no panics over the night. Thanks Oliver!
>
> Tested-by: Austin Schuh <austin@peloton-tech.com>
>
next prev parent reply other threads:[~2014-07-11 13:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 23:03 skbuff panic Austin Schuh
2014-07-03 23:18 ` Austin Schuh
2014-07-05 10:40 ` Oliver Hartkopp
2014-07-05 18:38 ` Austin Schuh
2014-07-05 19:21 ` Oliver Hartkopp
2014-07-06 5:07 ` Austin Schuh
2014-07-06 12:12 ` Oliver Hartkopp
2014-07-06 16:13 ` Oliver Hartkopp
2014-07-06 19:38 ` Marc Kleine-Budde
2014-07-07 4:11 ` Austin Schuh
2014-07-10 0:07 ` Austin Schuh
2014-07-10 17:37 ` Austin Schuh
2014-07-11 13:27 ` Oliver Hartkopp [this message]
2014-07-11 14:58 ` Austin Schuh
2014-07-11 17:48 ` Marc Kleine-Budde
2015-02-19 11:48 ` Daniel Steer
2015-02-23 12:55 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BFE637.2030905@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=austin@peloton-tech.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).