linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Ssagarr Patil <hugarsagar@outlook.com>,
	"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Subject: Re: C_CAN: can frame drops
Date: Fri, 25 Jul 2014 10:48:40 +0200	[thread overview]
Message-ID: <53D219E8.5060307@pengutronix.de> (raw)
In-Reply-To: <BAY176-W40C40CD192EBD241673159D3FC0@phx.gbl>

[-- Attachment #1: Type: text/plain, Size: 1571 bytes --]

On 07/25/2014 10:35 AM, Ssagarr Patil wrote:
>>>> ...and where is your stdout going? serial line, telnet, ssh?
>>>>
>>> Its the serial line.
>>
>> That's not good. As printing to the serial console is quite costly.
>>
> Yes agreed, although I also see some frame drops pointed by ifconfig can0
> when dumping it to file (with -l option of candump)
> I have also used chrt to increase the priority of candump.
> 
> Any suggestion on how to still improve the performance so as there is zero frame loss ?
> either on driver or application side.

Use the latest kernel, at least v3.15 which has tglx's patches
integrated. v3.16 might even be better. If you want to log all CAN
messages, you can probably make use of recvmmsg() to receive more than
one CAN frame at a time (instead of using recvmsg() or read()). When
writing to disk, don't write a single CAN frame at a time, it's better
to write large blocks, i.e. several 4k of data.

Depending on the actual c_can/d_can implementation you're using, there
might be some optimisation left in the driver, i.e. use 32 bit access if
possible. However before touching the driver, measurement to identify
the hot spots should be done.

The next step would be to switch to preempt rt enabled system.

Hope that helps,
Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]

  reply	other threads:[~2014-07-25  8:48 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-23 14:48 C_CAN: can frame drops Ssagarr Patil
2014-07-23 16:04 ` Oliver Hartkopp
2014-07-23 16:33   ` Ssagarr Patil
2014-07-24  7:40     ` Ssagarr Patil
2014-07-24 18:09       ` Oliver Hartkopp
2014-07-25  8:20         ` Ssagarr Patil
2014-07-25  7:17 ` Marc Kleine-Budde
2014-07-25  8:13   ` Ssagarr Patil
2014-07-25  8:16     ` Marc Kleine-Budde
2014-07-25  8:22       ` Ssagarr Patil
2014-07-25  8:27         ` Marc Kleine-Budde
2014-07-25  8:35           ` Ssagarr Patil
2014-07-25  8:48             ` Marc Kleine-Budde [this message]
2014-07-25  9:47               ` Ssagarr Patil
2014-07-25 10:10                 ` Marc Kleine-Budde
2014-07-25 11:22                   ` Ssagarr Patil
2014-07-25 10:43                 ` Oliver Hartkopp
2014-07-25 11:24                   ` Ssagarr Patil
2014-07-30 11:28                   ` Prabhakar Lad
2014-07-30 16:17                     ` Oliver Hartkopp
2014-07-31 12:41                       ` Ssagarr Patil
2014-07-31 12:42                         ` Marc Kleine-Budde
2014-07-31 14:11                           ` Oliver Hartkopp
2014-07-31 14:19                             ` Prabhakar Lad
2014-12-18  9:41                               ` [RFC] sched policies for candump Oliver Hartkopp
2014-12-18 12:33                                 ` Prabhakar Lad
2014-12-18 13:51                                   ` Oliver Hartkopp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D219E8.5060307@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=hugarsagar@outlook.com \
    --cc=linux-can@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).