From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
George Cherian <george.cherian@ti.com>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Thor Thayer <tthayer@altera.com>, Pavel Machek <pavel@denx.de>,
Mugunthan V N <mugunthanvnm@ti.com>,
"Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
Wolfram Sang <wsa@sang-engineering.com>,
linux-can@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] can: c_can: checking IS_ERR() instead of NULL
Date: Fri, 01 Aug 2014 11:15:05 +0200 [thread overview]
Message-ID: <53DB5A99.2050805@pengutronix.de> (raw)
In-Reply-To: <20140801091336.GK4804@mwanda>
[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]
On 08/01/2014 11:13 AM, Dan Carpenter wrote:
> On Fri, Aug 01, 2014 at 11:01:36AM +0200, Marc Kleine-Budde wrote:
>
>>> diff --git a/drivers/net/can/c_can/c_can_platform.c b/drivers/net/can/c_can/c_can_platform.c
>>> index 5dede6e..109cb44 100644
>>> --- a/drivers/net/can/c_can/c_can_platform.c
>>> +++ b/drivers/net/can/c_can/c_can_platform.c
>>> @@ -280,7 +280,7 @@ static int c_can_plat_probe(struct platform_device *pdev)
>>>
>>> priv->raminit_ctrlreg = devm_ioremap(&pdev->dev, res->start,
>>> resource_size(res));
>>> - if (IS_ERR(priv->raminit_ctrlreg) || priv->instance < 0)
>>> + if (!priv->raminit_ctrlreg || priv->instance < 0)
>>
>> What about using PTR_ERR_OR_ZERO()?
>
> No. It doesn't ever return a PTR_ERR(). Checking for that would just
> introduce a new static checker warning (signs of confusion may indicate
> buggy code).
Okay, thanks for the clarification.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]
next prev parent reply other threads:[~2014-08-01 9:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 8:53 [patch] can: c_can: checking IS_ERR() instead of NULL Dan Carpenter
2014-08-01 9:01 ` Marc Kleine-Budde
2014-08-01 9:13 ` Dan Carpenter
2014-08-01 9:15 ` Marc Kleine-Budde [this message]
2014-08-01 18:16 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DB5A99.2050805@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=dan.carpenter@oracle.com \
--cc=george.cherian@ti.com \
--cc=grant.likely@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=pavel@denx.de \
--cc=prabhakar.csengg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tthayer@altera.com \
--cc=wg@grandegger.com \
--cc=wsa@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).