linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: David Jander <david@protonic.nl>, wg@grandegger.com
Cc: linux-can@vger.kernel.org
Subject: Re: [PATCH 3/3] can: flexcan.c: Implement last step of workaround for errata ERR005829
Date: Tue, 02 Sep 2014 13:28:55 +0200	[thread overview]
Message-ID: <5405A9F7.5090004@pengutronix.de> (raw)
In-Reply-To: <1409133487-23367-4-git-send-email-david@protonic.nl>

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

On 08/27/2014 11:58 AM, David Jander wrote:
> It is not clear if this errata only applies to i.MX6, but the impact of
> the workaround should be minimal. Basically it comes down to reserving
> mailbox 0 as a permanently inactive MB and writing twice to its C/S field
> on every message transmit.
> 
> Signed-off-by: David Jander <david@protonic.nl>

Please fix this errata in one patch exactly. Please fix the errata
before introducing a new feature, i.e. rewriting of the RX path.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2014-09-02 11:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-27  9:58 [PATCH 0/3] Decrease likelyhood of RX overruns David Jander
2014-08-27  9:58 ` [PATCH 1/3] can: flexcan.c: Correctly initialize mailboxes David Jander
2014-09-02 10:24   ` Marc Kleine-Budde
2014-09-02 10:37     ` David Jander
2014-09-02 10:59       ` Marc Kleine-Budde
2014-09-02 11:15         ` David Jander
2014-09-02 13:54           ` Marc Kleine-Budde
2014-09-02 14:27             ` David Jander
2014-09-02 11:32         ` David Jander
2014-09-02 11:38           ` Marc Kleine-Budde
2014-09-02 14:53             ` Marc Kleine-Budde
2014-08-27  9:58 ` [PATCH 2/3] can: flexcan.c: Re-write receive path to use MB queue instead of FIFO David Jander
2014-09-02 11:30   ` Marc Kleine-Budde
2014-09-02 12:04     ` David Jander
2014-09-02 14:53       ` Marc Kleine-Budde
2014-09-03  7:19         ` David Jander
2014-09-03  9:12           ` Marc Kleine-Budde
2014-09-03 15:42     ` David Jander
2014-08-27  9:58 ` [PATCH 3/3] can: flexcan.c: Implement last step of workaround for errata ERR005829 David Jander
2014-09-02 11:28   ` Marc Kleine-Budde [this message]
2014-09-02 11:36     ` David Jander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5405A9F7.5090004@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=david@protonic.nl \
    --cc=linux-can@vger.kernel.org \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).