[PATCH 1/1] can: Avoid calling kfree_skb from interrupt context

[PATCH 1/1] can: Avoid calling kfree_skb from interrupt context

[Thomas Körper]

Called in can_free_echo_skb, which might be called from (TX Error) interrupt.

Signed-off-by: Thomas Körper <thomas.koerper@esd.eu>
---
 drivers/net/can/dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c
index 9f91fcb..6403503 100644
--- a/drivers/net/can/dev.c
+++ b/drivers/net/can/dev.c
@@ -383,7 +383,7 @@ void can_free_echo_skb(struct net_device *dev, unsigned int idx)
 	BUG_ON(idx >= priv->echo_skb_max);
 
 	if (priv->echo_skb[idx]) {
-		kfree_skb(priv->echo_skb[idx]);
+		dev_kfree_skb_any(priv->echo_skb[idx]);
 		priv->echo_skb[idx] = NULL;
 	}
 }
-- 
1.9.1

Re: [PATCH 1/1] can: Avoid calling kfree_skb from interrupt context

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

On 10/31/2014 07:33 AM, Thomas Körper wrote:
> Called in can_free_echo_skb, which might be called from (TX Error) interrupt.

Applied to can/master.

Thanks, Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]