From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Stephane Grosjean <s.grosjean@peak-system.com>,
linux-can@vger.kernel.org
Cc: Oliver Hartkopp <socketcan@hartkopp.net>
Subject: Re: [PATCH v2 1/3] can/peak_usb: CAN-FD: existing source files modifications
Date: Tue, 02 Dec 2014 13:14:29 +0100 [thread overview]
Message-ID: <547DAD25.10706@pengutronix.de> (raw)
In-Reply-To: <1417516314-17486-2-git-send-email-s.grosjean@peak-system.com>
[-- Attachment #1: Type: text/plain, Size: 768 bytes --]
On 12/02/2014 11:31 AM, Stephane Grosjean wrote:
> This patch does some modifications to the existing files that support the
> PEAK-System Technik CAN 2.0b USB adapters, for preparing the support of CAN-FD.
>
> In particular, this patch changes some static identifiers into global ones, to
> share common functionalities with the further incoming CAN-FD specific source
> files.
Have you read my review of the v1?
https://www.marc.info/?l=linux-can&m=141712364917425&w=2
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-12-02 12:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 10:31 [PATCH v2 0/3] Add support for PEAK CAN-FD USB adapters Stephane Grosjean
2014-12-02 10:31 ` [PATCH v2 1/3] can/peak_usb: CAN-FD: existing source files modifications Stephane Grosjean
2014-12-02 12:14 ` Marc Kleine-Budde [this message]
2014-12-02 13:07 ` Stephane Grosjean
2014-12-02 13:14 ` Marc Kleine-Budde
2014-12-02 10:31 ` [PATCH v2 2/3] can/peak_usb: CAN-FD: add new adapters specific files Stephane Grosjean
2014-12-02 10:31 ` [PATCH v2 3/3] can/peak_usb: CAN-FD: driver's core modifications Stephane Grosjean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547DAD25.10706@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=s.grosjean@peak-system.com \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).