Re: [PATCH 1/3] can/peak_usb: CAN-FD: existing source files modifications

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1651 bytes --]

On 12/02/2014 02:55 PM, Stephane Grosjean wrote:
>>> diff --git a/drivers/net/can/usb/peak_usb/pcan_usb.c
>>> b/drivers/net/can/usb/peak_usb/pcan_usb.c
>>> index 925ab8e..10a4ceb 100644
>>> --- a/drivers/net/can/usb/peak_usb/pcan_usb.c
>>> +++ b/drivers/net/can/usb/peak_usb/pcan_usb.c
>>> @@ -858,6 +858,7 @@ struct peak_usb_adapter pcan_usb = {
>>>       .name = "PCAN-USB",
>>>       .device_id = PCAN_USB_PRODUCT_ID,
>>>       .ctrl_count = 1,
>>> +    .ctrlmode_supported = CAN_CTRLMODE_3_SAMPLES |
>>> CAN_CTRLMODE_LISTENONLY,
>> This change seems unrelated to the make functions non static.
> 
> Ok.
> 
>>
>> and FTBFS:
>>
>>> linux/drivers/net/can/usb/peak_usb/pcan_usb.c:861:2: error: unknown
>>> field ‘ctrlmode_supported’ specified in initializer
>>>    .ctrlmode_supported = CAN_CTRLMODE_3_SAMPLES |
>>> CAN_CTRLMODE_LISTENONLY,
>>>    ^
>>> linux/drivers/net/can/usb/peak_usb/pcan_usb.c:861:2: warning:
>>> initialization makes pointer from integer without a cast
>>> linux/drivers/net/can/usb/peak_usb/pcan_usb.c:861:2: warning: (near
>>> initialization for ‘pcan_usb.intf_probe’)
> 
> well, this FTBS is "normal" while you doesn't apply PATCH 3/3. I thought
> a "serie" of patches was not cleavable... Can u confirm, please?

No, that would break bisection. The kernel must compile and work after
each patch.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]