Re: [PATCH 2/3] can/peak_usb: CAN-FD: add new adapters specific files

[Stephane Grosjean <s.grosjean@peak-system.com>]

Le 03/12/2014 11:50, Oliver Hartkopp a écrit :
> On 03.12.2014 11:45, Marc Kleine-Budde wrote:
>> On 12/03/2014 11:38 AM, Stephane Grosjean wrote:
>
>
>>> - pcan_ucan.h defines some data structs and constants that will be
>>> common across different kinds of CAN-FD hardwares. How should I include
>>> this "pcan_ucan.h" file from a future (for example) PCI CAN-FD driver
>>> (which, obvioulsy) won't be stored  under "usb/peak_usb" directory).
>>
>> If it's CAN-FD relevant than it will go under include/linux/can/ 
>> somewhere.
>
> Hm - AFAICS it's not a CAN FD specific thing but these definitions 
> belog to the ucan controller IP - similar to a M_CAN or C_CAN controller.
>
> So maybe it makes sense to create a
>
>     linux/drivers/net/can/ucan
>
> directory where the (new/current?) peak_pci cards with ucan might go 
> in too.
>
> The pcan_ucan.h is something like sja1000.h
>

Yes it is! But what about the new USB devices I'm pushing now? Is it 
possible to #include "pcan_ucan.h" from "usb/peak_usb" if it is stored 
into "ucan" ??? AFAIT it isn't without doing dirty things... but I'd 
like to be wrong...

> Regards,
> Oliver

--
PEAK-System Technik GmbH
Sitz der Gesellschaft Darmstadt
Handelsregister Darmstadt HRB 9183 
Geschaeftsfuehrung: Alexander Gach, Uwe Wilhelm
--