From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephane Grosjean Subject: Re: [PATCH 2/3] can/peak_usb: CAN-FD: add new adapters specific files Date: Wed, 03 Dec 2014 12:20:14 +0100 Message-ID: <547EF1EE.4050409@peak-system.com> References: <5477A5A3.9070107@pengutronix.de> <547DBAEC.6010903@pengutronix.de> <547DD608.5090403@peak-system.com> <547DD81B.9000403@pengutronix.de> <547EDA21.6030802@peak-system.com> <547EE315.40703@hartkopp.net> <547EE827.2080004@peak-system.com> <547EE9CA.8070608@pengutronix.de> <547EEAFA.6050203@hartkopp.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail.peak-system.com ([213.157.13.214]:52069 "EHLO mail.peak-system.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751629AbaLCLUU (ORCPT ); Wed, 3 Dec 2014 06:20:20 -0500 In-Reply-To: <547EEAFA.6050203@hartkopp.net> Sender: linux-can-owner@vger.kernel.org List-ID: To: Oliver Hartkopp , Marc Kleine-Budde , "linux-can@vger.kernel.org" Le 03/12/2014 11:50, Oliver Hartkopp a =C3=A9crit : > On 03.12.2014 11:45, Marc Kleine-Budde wrote: >> On 12/03/2014 11:38 AM, Stephane Grosjean wrote: > > >>> - pcan_ucan.h defines some data structs and constants that will be >>> common across different kinds of CAN-FD hardwares. How should I inc= lude >>> this "pcan_ucan.h" file from a future (for example) PCI CAN-FD driv= er >>> (which, obvioulsy) won't be stored under "usb/peak_usb" directory)= =2E >> >> If it's CAN-FD relevant than it will go under include/linux/can/=20 >> somewhere. > > Hm - AFAICS it's not a CAN FD specific thing but these definitions=20 > belog to the ucan controller IP - similar to a M_CAN or C_CAN control= ler. > > So maybe it makes sense to create a > > linux/drivers/net/can/ucan > > directory where the (new/current?) peak_pci cards with ucan might go=20 > in too. > > The pcan_ucan.h is something like sja1000.h > Yes it is! But what about the new USB devices I'm pushing now? Is it=20 possible to #include "pcan_ucan.h" from "usb/peak_usb" if it is stored=20 into "ucan" ??? AFAIT it isn't without doing dirty things... but I'd=20 like to be wrong... > Regards, > Oliver -- PEAK-System Technik GmbH Sitz der Gesellschaft Darmstadt Handelsregister Darmstadt HRB 9183=20 Geschaeftsfuehrung: Alexander Gach, Uwe Wilhelm --