Re: [PATCH 2/3] can/peak_usb: CAN-FD: add new adapters specific files

[Oliver Hartkopp <socketcan@hartkopp.net>]

Then I would suggest to stay in the layout of the current patch set (with 
pcan_ucan.h in drivers/usb/peak_usb) and discuss about a generic approach when 
some other ucan-based devices (e.g. pci) appear ...

?!?

Regards,
Oliver

On 03.12.2014 13:34, Stephane Grosjean wrote:
>
> Le 03/12/2014 12:51, Oliver Hartkopp a écrit :
>> On 03.12.2014 12:20, Stephane Grosjean wrote:
>>
>>>> So maybe it makes sense to create a
>>>>
>>>>     linux/drivers/net/can/ucan
>>>>
>>>> directory where the (new/current?) peak_pci cards with ucan might go in too.
>>>>
>>>> The pcan_ucan.h is something like sja1000.h
>>>>
>>>
>>> Yes it is! But what about the new USB devices I'm pushing now? Is it possible
>>> to #include "pcan_ucan.h" from "usb/peak_usb" if it is stored into "ucan" ???
>>> AFAIT it isn't without doing dirty things... but I'd like to be wrong...
>>
>> Yes. That would look ugly.
>>
>> I wonder if it makes send to leave the drivers in
>>
>>     drivers/net/can/sja1000
>> and
>>
>>     drivers/net/can/usb/peak_usb
>>
>> as-is and put the new ucan based adapters (usb/pci/ ...) into
>>
>>     drivers/net/can/ucan
>>
>> ???
>>
>> Do you assume this to create a code duplication problem for the USB drivers?
>
> Arf I'm afraid it would... I managed to create a "peak usb core" to minimize
> code duplication, with device specific files around, so that it would be
> easier to add any new usb devices. In fact it was. Until "ucan" came into the
> story...
>
>>
>> @Marc: Any suggestion from you?
>>
>> Regards,
>> Oliver
>
> --
> PEAK-System Technik GmbH
> Sitz der Gesellschaft Darmstadt
> Handelsregister Darmstadt HRB 9183 Geschaeftsfuehrung: Alexander Gach, Uwe
> Wilhelm
> --