From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Andri Yngvason <andri.yngvason@marel.com>, linux-can@vger.kernel.org
Cc: wg@grandegger.com
Subject: Re: [PATCH v5 5/5] can: move can_stats.bus_off++ from can_bus_off into can_change_state
Date: Sun, 07 Dec 2014 21:15:42 +0100 [thread overview]
Message-ID: <5484B56E.10607@pengutronix.de> (raw)
In-Reply-To: <470b7276-2306-4075-814b-7ebd624903dc@GRBSR0089.marel.net>
[-- Attachment #1: Type: text/plain, Size: 1903 bytes --]
On 12/03/2014 06:54 PM, Andri Yngvason wrote:
> In order to be able to move the stats increment from can_bus_off() into
> can_change_state(), the increment had to be moved back into code that was using
> can_bus_off() but not can_change_state().
>
> Signed-off-by: Andri Yngvason <andri.yngvason@marel.com>
> ---
> drivers/net/can/bfin_can.c | 1 +
> drivers/net/can/c_can/c_can.c | 1 +
> drivers/net/can/cc770/cc770.c | 1 +
> drivers/net/can/dev.c | 3 ++-
> drivers/net/can/m_can/m_can.c | 1 +
> drivers/net/can/pch_can.c | 1 +
> drivers/net/can/rcar_can.c | 1 +
> drivers/net/can/softing/softing_main.c | 1 +
> drivers/net/can/spi/mcp251x.c | 1 +
> drivers/net/can/ti_hecc.c | 1 +
> drivers/net/can/usb/ems_usb.c | 1 +
> drivers/net/can/usb/esd_usb2.c | 1 +
> drivers/net/can/usb/peak_usb/pcan_usb.c | 1 +
> drivers/net/can/usb/peak_usb/pcan_usb_pro.c | 1 +
> drivers/net/can/usb/usb_8dev.c | 1 +
> 15 files changed, 16 insertions(+), 1 deletion(-)
What about:
> drivers/net/can/c_can/c_can.c-910- cf->can_id |= CAN_ERR_BUSOFF;
> drivers/net/can/c_can/c_can.c:911: can_bus_off(dev);
> drivers/net/can/janz-ican3.c-1010- cf->can_id |= CAN_ERR_BUSOFF;
> drivers/net/can/janz-ican3.c:1011: can_bus_off(dev);
> drivers/net/can/xilinx_can.c-560- priv->write_reg(priv, XCAN_SRR_OFFSET, XCAN_SRR_RESET_MASK);
> drivers/net/can/xilinx_can.c:561: can_bus_off(ndev);
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-12-07 20:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 17:54 [PATCH v5 5/5] can: move can_stats.bus_off++ from can_bus_off into can_change_state Andri Yngvason
2014-12-07 20:15 ` Marc Kleine-Budde [this message]
2014-12-08 10:44 ` Andri Yngvason
2014-12-08 11:24 ` Wolfgang Grandegger
2014-12-08 11:39 ` Andri Yngvason
2014-12-08 17:45 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5484B56E.10607@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=andri.yngvason@marel.com \
--cc=linux-can@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).