[info] Kconfig SELECT statement rules - was: FIXED_PHY is broken...

[info] Kconfig SELECT statement rules - was: FIXED_PHY is broken...

[Oliver Hartkopp]

Just a hint from Dave when the SELECT statement is not appropriate when 
creating Kconfig files ... ;-)

Regards,
Oliver


-------- Forwarded Message --------
Subject: FIXED_PHY is broken...
Date: Tue, 16 Dec 2014 11:25:34 -0500 (EST)
From: David Miller <davem@davemloft.net>
To: netdev@vger.kernel.org
CC: f.fainelli@gmail.com


I get this now when I run oldconfig:

warning: (NET_DSA_BCM_SF2 && BCMGENET && SYSTEMPORT) selects FIXED_PHY which 
has unmet direct dependencies (NETDEVICES && PHYLIB=y)

For the thousandth time, you cannot select Kconfig options which have
dependencies of any kind, because select does not recursively cause
dependencies to be enabled up to the root of the Kconfig tree.

If you select on something which has a "depends on", stop right there
because you can't do it.

It only works for pure leaf Kconfig nodes with no deps.

All you needed to do in order to test this was do an allmodconfig
build.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html