From: Oliver Hartkopp <socketcan@hartkopp.net>
To: "Wu, Aaron" <Aaron.Wu@analog.com>,
"adi-buildroot-devel@lists.sourceforge.net"
<adi-buildroot-devel@lists.sourceforge.net>,
"wg@grandegger.com" <wg@grandegger.com>,
"mkl@pengutronix.de" <mkl@pengutronix.de>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] bfin_can: move the header file to arch independent location
Date: Mon, 29 Dec 2014 17:04:19 +0100 [thread overview]
Message-ID: <54A17B83.60206@hartkopp.net> (raw)
In-Reply-To: <649EF91064D35D40B9C93A225BF41674612CCDB7@NWD2MBX7.ad.analog.com>
Hi Aaron,
On 12/29/2014 03:32 AM, Wu, Aaron wrote:
>> From: Oliver Hartkopp [mailto:socketcan@hartkopp.net]
>> So the correct way is to check which defines are *really* referenced and add
>> these directly to bfin_can.c (the only user) when removing bfin_can.h
>
> Thanks for reply, will merge your idea and be back.
Great. As there's so many unused stuff in bfin_can.h I assume this to be a
real good improvement.
> Also your comments about another of my recent patch " Rewrite the blackfin CAN driver into arch independent style" is welcome.
This looks good to ME but usually Marc maintains the driver portions - and I
don't really know if it just *looks* good or if it *is* good ;-)
I just wanted to comment on the include file - as I knew the potential
feedback from Marc there. For the rest we need to wait for Marc coming back
from vacation.
Best regards,
Oliver
next prev parent reply other threads:[~2014-12-29 16:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-26 3:07 [PATCH] bfin_can: move the header file to arch independent location Aaron Wu
2014-12-27 11:09 ` Oliver Hartkopp
2014-12-29 2:32 ` Wu, Aaron
2014-12-29 16:04 ` Oliver Hartkopp [this message]
[not found] ` <5234314.TQCbV9cZp1@heinz>
2014-12-29 17:36 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A17B83.60206@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=Aaron.Wu@analog.com \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).