From: Oliver Hartkopp <socketcan@hartkopp.net>
To: "Heinz-Jürgen Oertel" <hj.oertel@t-online.de>, mkl@pengutronix.de
Cc: Aaron Wu <Aaron.wu@analog.com>,
linux-can@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bfin_can: move the header file to arch independent location
Date: Mon, 29 Dec 2014 18:36:35 +0100 [thread overview]
Message-ID: <54A19123.5040708@hartkopp.net> (raw)
In-Reply-To: <5234314.TQCbV9cZp1@heinz>
On 12/29/2014 05:45 PM, Heinz-Jürgen Oertel wrote:
> Am Samstag, 27. Dezember 2014, 12:09:30 schrieb Oliver Hartkopp:
>> As bfin_can.c is the only user of defines from this include file just add the
>> needed(!) defines directly to bfin_can.c
>
> I often include also the yet unneeded definitions, e.g., for unused register or unused bit definitions.
> That makes it easier for someone else to add missing functionality, when later on needed.
>
Yes. This can be useful when you can imagine to add functionality into a
specific direction. But in this case there were tons of mailbox definitions
(always defined 32 times each) which we will not use in this way in the netdev
driver.
Just take a look into bfin_can.h and what is really used in bfin_can.c from
those defines and you will see.
Regards,
Oliver
prev parent reply other threads:[~2014-12-29 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-26 3:07 [PATCH] bfin_can: move the header file to arch independent location Aaron Wu
2014-12-27 11:09 ` Oliver Hartkopp
2014-12-29 2:32 ` Wu, Aaron
2014-12-29 16:04 ` Oliver Hartkopp
[not found] ` <5234314.TQCbV9cZp1@heinz>
2014-12-29 17:36 ` Oliver Hartkopp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A19123.5040708@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=Aaron.wu@analog.com \
--cc=hj.oertel@t-online.de \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).