From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>,
Wolfgang Grandegger <wg@grandegger.com>
Cc: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Subject: Re: [PATCH stable] can_dev: fix crtlmode_supported check
Date: Wed, 07 Jan 2015 14:11:53 +0100 [thread overview]
Message-ID: <54AD3099.3000505@pengutronix.de> (raw)
In-Reply-To: <54AD2E3D.2080908@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1323 bytes --]
On 01/07/2015 02:01 PM, Marc Kleine-Budde wrote:
> On 01/05/2015 06:40 PM, Oliver Hartkopp wrote:
>> When changing flags in the CAN drivers ctrlmode the provided new content
>> has to be checked whether the bits are allowed to be changed.
>> The bits that are to be changed are given as a bitfield in cm->mask.
>> Therefore checking against cm->flags is wrong as the content can hold
>> any kind of values.
>>
>> The iproute2 tool sets the bits in cm->mask and cm->flags depending on
>> the detected command line options. To be robust against bogus user space
>> applications additionally sanitize the provided flags with the provided
>> mask.
>>
>> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
>> CC: Wolfgang Grandegger <wg@grandegger.com>
>
> Does not apply to net/master. However I've applied it by hand. v2 will
> follow.
> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0
You should consider to use git send-email instead of thunderbird to post
your patches :)
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-01-07 13:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 17:40 [PATCH stable] can_dev: fix crtlmode_supported check Oliver Hartkopp
2015-01-07 13:01 ` Marc Kleine-Budde
2015-01-07 13:11 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AD3099.3000505@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).