From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
Stephane Grosjean <s.grosjean@peak-system.com>,
linux-can@vger.kernel.org
Subject: Re: [PATCH v4] can/peak_usb: add support for PEAK new CANFD USB adapters
Date: Wed, 07 Jan 2015 18:37:28 +0100 [thread overview]
Message-ID: <54AD6ED8.2020808@hartkopp.net> (raw)
In-Reply-To: <54AD66C5.10908@pengutronix.de>
On 07.01.2015 18:03, Marc Kleine-Budde wrote:
> On 01/06/2015 11:00 AM, Stephane Grosjean wrote:
>> Add support for the following new PEAK-System technik CANFD USB adapters:
>>
>> PCAN-USB FD single CANFD channel USB adapter
>> PCAN-USB Pro FD dual CANFD channels USB adapter
>
> Can you please work out the correct ISO/non-ISO for CAN-fd with Oliver.
> If you need CAN_CTRLMODE_FD_NON_ISO make your patch based on
>
> https://gitorious.org/linux-can/linux-can.git testing
>
Good idea.
@Stephane: Do you already have the latest UCAN IP core from Philipp which
supports the ISO/non-ISO switching? (I don't have it)
The question is if it makes sense to provide a driver for the current UCAN IP
core and later provide a separate patch when the new (switchable) UCAN IP core
is available.
But in this case we need to check for the UCAN revision whether it is fixed to
non-ISO or if it is switchable.
Maybe it makes sense to support ONLY the latest (== switchable) UCAN revision
for the mainline driver. The update to the latest UCAN revision is mandatory
anyway.
What is your suggestion?
Regards,
Oliver
next prev parent reply other threads:[~2015-01-07 17:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 10:00 [PATCH v4] can/peak_usb: add support for PEAK new CANFD USB adapters Stephane Grosjean
2015-01-07 17:03 ` Marc Kleine-Budde
2015-01-07 17:37 ` Oliver Hartkopp [this message]
2015-01-07 18:37 ` iproute2 fd-non-iso PoC - was " Oliver Hartkopp
2015-01-08 9:04 ` Marc Kleine-Budde
2015-01-08 9:09 ` Marc Kleine-Budde
2015-01-13 13:18 ` Stephane Grosjean
2015-01-13 13:29 ` Marc Kleine-Budde
2015-01-13 13:32 ` Marc Kleine-Budde
2015-01-14 10:50 ` Stephane Grosjean
2015-01-14 10:51 ` Marc Kleine-Budde
2015-01-14 10:56 ` Stephane Grosjean
2015-01-14 11:07 ` Marc Kleine-Budde
2015-01-14 18:55 ` Oliver Hartkopp
2015-01-14 20:57 ` Marc Kleine-Budde
2015-01-15 15:49 ` Marc Kleine-Budde
2015-01-14 12:05 ` Fwd: " Stephane Grosjean
2015-01-14 13:00 ` Andri Yngvason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AD6ED8.2020808@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=s.grosjean@peak-system.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).