From: Oliver Hartkopp <socketcan@hartkopp.net>
To: laurent vaudoit <laurent.vaudoit@gmail.com>
Cc: maxime@artisandeveloppeur.fr, linux-can@vger.kernel.org
Subject: Re: linux-can ISOTP module
Date: Fri, 16 Jan 2015 18:31:40 +0100 [thread overview]
Message-ID: <54B94AFC.9080201@hartkopp.net> (raw)
In-Reply-To: <CAA7hF3ypuVbfxbskM+2bn_58a-k0EtCePxQ_1i6j24G5H=zFSQ@mail.gmail.com>
On 15.01.2015 09:45, laurent vaudoit wrote:
> On Thu, Nov 13, 2014 at 6:47 PM, Oliver Hartkopp <socketcan@hartkopp.net
> >> I added the funtionality of a different rx_ext_addr to a specific branch of
> >> can-utils and can-modules:
> >>
> >>https://gitorious.org/linux-can/can-utils/commits/rx_ext_addr
> >>https://gitorious.org/linux-can/can-modules/commits/rx_ext_addr
> >>
> >> Please check them out for a test. As all the isotp tools (in the branch)
> >> support the new feature too, it should be easy to do.
> >
> > i did not have time for test but regarding the source code, it should be ok.
(..)
>
> it works well.
> I've made some tests sending single frame and segmented frame
> and receiving some single frame, with different extended adressing mode.
>
> We are now able to deal with all the addressing method of the Iso15765-2.
Great! Many thanks for testing!
> Branch can be merge (by the way it seems kernel evolution is allready merged
> into master).
Yes, I had some other stuff to add for a complete ISO15765-2:2015 support,
e.g. the 32 bit FF_DL and the checks for optimized frame length.
So I needed to extend the API step by step and the rx_ext_addr was already
defined - therefore it was hard to continue with integrating new features.
But it's good to know that it fits your needs and the isotp got 'even better'
for all use cases in the wild :-)
Best regards,
Oliver
next prev parent reply other threads:[~2015-01-16 17:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 12:55 linux-can ISOTP module laurent vaudoit
2014-06-04 18:40 ` Oliver Hartkopp
2014-06-05 7:16 ` laurent vaudoit
2014-06-05 10:18 ` Maxime Jayat
2014-06-05 18:22 ` Oliver Hartkopp
2014-06-06 6:42 ` laurent vaudoit
2014-06-20 19:08 ` Oliver Hartkopp
2014-06-23 18:01 ` laurent vaudoit
2014-11-13 17:47 ` Oliver Hartkopp
[not found] ` <CAA7hF3ypuVbfxbskM+2bn_58a-k0EtCePxQ_1i6j24G5H=zFSQ@mail.gmail.com>
2015-01-16 17:31 ` Oliver Hartkopp [this message]
2014-06-21 11:18 ` N_Cs timing - was " Oliver Hartkopp
2014-06-23 18:13 ` laurent vaudoit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B94AFC.9080201@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=laurent.vaudoit@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=maxime@artisandeveloppeur.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).