Linux CAN drivers development
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
	Stephane Grosjean <s.grosjean@peak-system.com>
Cc: linux-can@vger.kernel.org
Subject: Re: [PATCH] can/peak_usb: mark current PEAK USB FD as non-ISO
Date: Tue, 27 Jan 2015 19:10:16 +0100	[thread overview]
Message-ID: <54C7D488.4010203@hartkopp.net> (raw)
In-Reply-To: <1422381484-3804-1-git-send-email-socketcan@hartkopp.net>

Hello Marc,

your v10 series looks very good. The ARRAY_SIZE stuff is a good improvement!

I compiled the peak-next branch and inserting my single PCAN USB FD adapter 
worked fine. I'll send my tested-by when I can access my second adapter at 
work tomorrow.

The  patch below finally sets the CAN_CTRLMODE_FD_NON_ISO flag.
It's tested with the updated ip tool.

But beware: The current linux-can-next is missing the CAN_CTRLMODE_FD_NON_ISO 
patch for M_CAN. Therefore CAN_CTRLMODE_FD_NON_ISO is not defined until Dave 
pulled net into net-next. So this patch creates a compile error in the latest 
linux-can-next.

Regards,
Oliver

On 27.01.2015 18:58, Oliver Hartkopp wrote:
> The current PCAN USB FD (pro) adapters support the non-ISO CAN FD protocol.
>
> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
> ---
>   drivers/net/can/usb/peak_usb/pcan_usb_fd.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_fd.c b/drivers/net/can/usb/peak_usb/pcan_usb_fd.c
> index e4d9354..962c3f0 100644
> --- a/drivers/net/can/usb/peak_usb/pcan_usb_fd.c
> +++ b/drivers/net/can/usb/peak_usb/pcan_usb_fd.c
> @@ -860,6 +860,9 @@ static int pcan_usb_fd_init(struct peak_usb_device *dev)
>   			 pdev->usb_if->fw_info.fw_version[2],
>   			 dev->adapter->ctrl_count);
>
> +		/* the currently supported hw is non-ISO */
> +		dev->can.ctrlmode = CAN_CTRLMODE_FD_NON_ISO;
> +
>   		/* tell the hardware the can driver is running */
>   		err = pcan_usb_fd_drv_loaded(dev, 1);
>   		if (err) {
>

  reply	other threads:[~2015-01-27 18:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-27 17:58 [PATCH] can/peak_usb: mark current PEAK USB FD as non-ISO Oliver Hartkopp
2015-01-27 18:10 ` Oliver Hartkopp [this message]
2015-01-27 18:25   ` Marc Kleine-Budde
2015-01-27 19:19     ` Oliver Hartkopp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C7D488.4010203@hartkopp.net \
    --to=socketcan@hartkopp.net \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=s.grosjean@peak-system.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox