From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Dan Carpenter <dan.carpenter@oracle.com>, ahmed.darwish@valeo.com
Cc: linux-can@vger.kernel.org
Subject: Re: can: kvaser_usb: Consolidate and unify state change handling
Date: Thu, 05 Feb 2015 09:17:53 +0100 [thread overview]
Message-ID: <54D32731.2070106@pengutronix.de> (raw)
In-Reply-To: <20150205081239.GA30683@mwanda>
[-- Attachment #1: Type: text/plain, Size: 955 bytes --]
Hey Dan,
On 02/05/2015 09:12 AM, Dan Carpenter wrote:
> The patch 96d7f10634e6: "can: kvaser_usb: Consolidate and unify state
> change handling" from Jan 26, 2015, leads to the following Smatch
> warning:
>
> drivers/net/can/usb/kvaser_usb.c:827 kvaser_usb_rx_error_update_can_state()
> warn: impossible condition '(es->txerr >= 256) => (0-255 >= 256)'
A patch that implicitly fixes this warning, along with other
things, is in my latest pull request to David Miller.
can: kvaser_usb: Ignore spurious error events after a busoff
http://article.gmane.org/gmane.linux.can/7587
http://www.spinics.net/lists/netdev/msg315062.html
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-02-05 8:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 8:12 can: kvaser_usb: Consolidate and unify state change handling Dan Carpenter
2015-02-05 8:17 ` Marc Kleine-Budde [this message]
2015-02-05 8:30 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D32731.2070106@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=ahmed.darwish@valeo.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-can@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox