From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Hartkopp Subject: Re: [PATCH] can: use sock_efree instead of own destructor Date: Tue, 10 Mar 2015 15:55:32 +0100 Message-ID: <54FF05E4.6060002@hartkopp.net> References: <1425959300-27132-1-git-send-email-fw@strlen.de> <54FE8BB0.9050508@hartkopp.net> <1425990143.8261.28.camel@edumazet-glaptop2.roam.corp.google.com> <54FEF355.305@hartkopp.net> <1425998185.8261.51.camel@edumazet-glaptop2.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.221]:19000 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751173AbbCJOzj (ORCPT ); Tue, 10 Mar 2015 10:55:39 -0400 In-Reply-To: <1425998185.8261.51.camel@edumazet-glaptop2.roam.corp.google.com> Sender: linux-can-owner@vger.kernel.org List-ID: To: Eric Dumazet Cc: Florian Westphal , netdev@vger.kernel.org, mkl@pengutronix.de, "linux-can@vger.kernel.org" , Alexander Duyck On 03/10/2015 03:36 PM, Eric Dumazet wrote: > On Tue, 2015-03-10 at 14:36 +0100, Oliver Hartkopp wrote: >> Maybe Alexander can send a patch which adds a comment, as I don't know if I >> would find the best words for it. > > Please do not top post on netdev. ? I did not. > If you cannot find best words for it, maybe a comment would not be > useful : Very often, best comments are added by people that had problems > to understand the code ;) Yes that's why I asked the original author to do so - he hopefully understood his code :-) > > I do not trust comments, I prefer using "git grep" or tools like that to > check call sites. > > In this particular case this becomes clear, while being concise. > > # git grep -n sock_efree A good hint! Will use this first in the future. Thanks, Oliver