Re: ems_usb: endianess warning

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1349 bytes --]

On 03/25/2015 09:34 AM, Marc Kleine-Budde wrote:
> On 03/24/2015 07:02 PM, Gerhard Uttenthaler wrote:
>> this took some time, sorry.
> 
> Thanks, applied to can.

I missed the fact, that the ID is correct in the driver without the
patch, sparse just missed that. So this goes into can-next.

In the driver there's timestamp, which endianess is corret here?

> /* Main message type used between library and application */
> struct __packed ems_cpc_msg {
> 	u8 type;	/* type of message */
> 	u8 length;	/* length of data within union 'msg' */
> 	u8 msgid;	/* confirmation handle */
> 	u32 ts_sec;	/* timestamp in seconds */
> 	u32 ts_nsec;	/* timestamp in nano seconds */
        ^^^^^^^^^^^
> 
> 	union {
> 		u8 generic[64];
> 		struct cpc_can_msg can_msg;
> 		struct cpc_can_params can_params;
> 		struct cpc_confirm confirmation;
> 		struct cpc_overrun overrun;
> 		struct cpc_can_error error;
> 		struct cpc_can_err_counter err_counter;
> 		u8 can_state;
> 	} msg;
> };

I know, the timestamp is not used in the driver, for now.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]