Re: [PATCH 3/3] can: flexcan: Add support for non RX-FIFO mode and ERRATA ERR005829

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 2231 bytes --]

On 04/27/2015 08:38 AM, bhupesh.sharma@freescale.com wrote:
> Hi Marc,
> 
> Sorry for the late reply.
> 
>> On 04/09/2015 06:17 PM, bhupesh.sharma@freescale.com wrote:
>>>> From: Marc Kleine-Budde [mailto:mkl@pengutronix.de] On 04/09/2015
>>>> 05:53 PM, bhupesh.sharma@freescale.com wrote:
>>>>>> Please look at the mainline commit:
>>>>>>
>>>>>> 25e924450fcb can: flexcan: implement workaround for errata
>>>>>> ERR005829
>>>>>
>>>>> Hmm.. This looks like a fairly simple ERRATA to be handled w/o
>> Kconfig.
>>>>> But with the legacy mode support ERRATA, we have completely
>>>>> different RX setups for the legacy and FIFO mode.
>>>>
>>>> Can you give me link to the "ERRATA ERR005829 (A-008965)" description?
>>>>
>>>> The errata ERR005829 is described here
>>>> http://cache.freescale.com/files/32bit/doc/errata/IMX6DQCE.pdf and
>>>> it's fixed by mainline commit:
>>>>
>>>>     25e924450fcb can: flexcan: implement workaround for errata
>>>> ERR005829
>>>>
>>>> Is your "ERRATA ERR005829 (A-008965)" something different?
>>>
>>> Yes. I mixed up the errata numbers in the git log by mistake.
>>>
>>> Its number A-008965 and is related to LS1021A FlexCAN not being able
>>> to support RX-FIFO mode.
>>
>> Do you have a link to the errata? Where's the corresponding kconfig
>> patch? Why do you have to switch on/off the errata by kconfig? Is there a
>> LS1021A without the bug?
> 
> The errata list is not available for public access on www.freescale.com so far.
> The next version of LS1021A SoC, is fixing this bug and since both are supposed
> to be used by customers, the kconfig trick is required to turn-off this handling
> for one version, while keeping it intact for the other.

Sorry, a compile time switch is not an option here. Please configure it
during runtime via the device tree. This can be done by different
compatibles, one for the broken another one for the fixed SoC.

regards,
Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]