From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Jeppe Ledet-Pedersen <jlp@gomspace.com>,
wg@grandegger.com, michal.simek@xilinx.com,
soren.brinkmann@xilinx.com, appana.durga.rao@xilinx.com
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: can: xilinx_can: fix extended frame handling
Date: Fri, 1 May 2015 10:20:35 +0200 [thread overview]
Message-ID: <55433753.5050500@pengutronix.de> (raw)
In-Reply-To: <1430319901-19242-1-git-send-email-jlp@gomspace.com>
[-- Attachment #1: Type: text/plain, Size: 916 bytes --]
On 04/29/2015 05:05 PM, Jeppe Ledet-Pedersen wrote:
> Using IDR_SRR in RXFIFO_ID to test for the presence of data is only
> valid for standard frames. For extended frames the bit is always 1 and
> IDR_RTR should be used instead. This patch switches the check to use
> CAN_RTR_FLAG which is correctly set when reading the ID.
>
> The patch also changes the DW1/DW2 to be read unconditionally, since
> this is necessary to remove the frame from the RXFIFO.
>
> Signed-off-by: Jeppe Ledet-Pedersen <jlp@gomspace.com>
> Acked-by: Kedareswara rao Appana <appanad@xilinx.com>
Applied to can. Added stable on Cc.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2015-05-01 8:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 15:05 [PATCH] net: can: xilinx_can: fix extended frame handling Jeppe Ledet-Pedersen
2015-05-01 8:20 ` Marc Kleine-Budde [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-05-01 8:28 pull-request: can 2015-05-01 Marc Kleine-Budde
2015-05-01 8:28 ` [PATCH] net: can: xilinx_can: fix extended frame handling Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55433753.5050500@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=appana.durga.rao@xilinx.com \
--cc=jlp@gomspace.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=soren.brinkmann@xilinx.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).