[PATCH] add 'v' command response

[PATCH] add 'v' command response

[Marc Kleine-Budde]

From: bombilee <chenglung@gmail.com>

add v command response. Some software like USBtinViewer using v for software version.
Tested on USBtinViewer 1.0
---
Hello,

this just came in via gibhub.

Marc

 slcanpty.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/slcanpty.c b/slcanpty.c
index c062a027da41..f485ac775a53 100644
--- a/slcanpty.c
+++ b/slcanpty.c
@@ -185,6 +185,13 @@ rx_restart:
 		ptr = 1;
 		goto rx_out;
 	}
+	/* check for 'v'ersion command */
+	if (cmd == 'v') {
+		sprintf(replybuf, "v1014\r");
+		tmp = strlen(replybuf);
+		ptr = 1;
+		goto rx_out;
+	}
 
 	/* check for serial 'N'umber command */
 	if (cmd == 'N') {
-- 
2.1.4

Re: [PATCH] add 'v' command response

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]

Hello bombilee,

On 05/07/2015 04:20 PM, Marc Kleine-Budde wrote:
> diff --git a/slcanpty.c b/slcanpty.c
> index c062a027da41..f485ac775a53 100644
> --- a/slcanpty.c
> +++ b/slcanpty.c
> @@ -185,6 +185,13 @@ rx_restart:
>  		ptr = 1;
>  		goto rx_out;
>  	}
> +	/* check for 'v'ersion command */
> +	if (cmd == 'v') {
> +		sprintf(replybuf, "v1014\r");

Is there a special meaning behing "v1014"? Where does the string come from?

> +		tmp = strlen(replybuf);
> +		ptr = 1;
> +		goto rx_out;
> +	}
>  
>  	/* check for serial 'N'umber command */
>  	if (cmd == 'N') {
> 

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [PATCH] add 'v' command response

[Oliver Hartkopp]

Hi all

On 05/07/2015 04:24 PM, Marc Kleine-Budde wrote:
> Hello bombilee,
> 
> On 05/07/2015 04:20 PM, Marc Kleine-Budde wrote:
>> diff --git a/slcanpty.c b/slcanpty.c
>> index c062a027da41..f485ac775a53 100644
>> --- a/slcanpty.c
>> +++ b/slcanpty.c
>> @@ -185,6 +185,13 @@ rx_restart:
>>  		ptr = 1;
>>  		goto rx_out;
>>  	}
>> +	/* check for 'v'ersion command */
>> +	if (cmd == 'v') {
>> +		sprintf(replybuf, "v1014\r");
> 
> Is there a special meaning behing "v1014"? Where does the string come from?

We *already* check for the version command!

But it has to be 'V' with upper case:

See http://www.can232.com/docs/can232_v3.pdf page 12:

Get Version number of both CAN232 hardware and software
This command is only active always.
Example: V[CR]
Get Version numbers
Returns: V and a 2 bytes BCD value for hardware version and
a 2 byte BCD value for software version plus
CR (Ascii 13) for OK. E.g. V1013[CR]

The SLCAN/Lawicel protocol is case sensitive!!

See T/t R/r S/s M/m commands.

A hunk could be to support lower case for the version information check too.

But IMO that's the wrong approach.

The application should send 'V' and not 'v' - and this should be fixed there.

What kind of application sends 'v' to get the version information?

Regards,
Oliver

> 
>> +		tmp = strlen(replybuf);
>> +		ptr = 1;
>> +		goto rx_out;
>> +	}
>>  
>>  	/* check for serial 'N'umber command */
>>  	if (cmd == 'N') {
>>
> 
> Marc
> 

Re: [PATCH] add 'v' command response

[Oliver Hartkopp]

On 05/08/2015 04:18 AM, Cheng-Lung Lee wrote:

> I am using USBtin device software(http://www.fischl.de/usbtin/ ) which like
> some SLCAN based serial CAN protocol using "v" as Major/Minor version number.
> Please check the pdf file for more detial.
> http://www.mirrorservice.org/sites/downloads.sourceforge.net/s/so/socketcan.berlios/SLCAN-API.pdf

Whoa!

That's pretty hard to be pointed at my *own* created documentation after seven
years m)

Indeed you are right. To emulate the SLCAN adapter with the slcanpty emulation
this patch makes perfectly sense.

I pulled your changes into can-utils:master.

Best regards,
Oliver

ps. The pointer to http://www.fischl.de/usbtin/ was interesting.

> The software I am testing is USBtinViewer, which sends "V" and "v" on startup.
> If slcanpty sends NACK . The program quits.
> 
> Best,
> Steven
> 
> On Thu, May 7, 2015 at 4:57 PM, Oliver Hartkopp <socketcan@hartkopp.net
> <mailto:socketcan@hartkopp.net>> wrote:
> 
>     Hi all
> 
>     On 05/07/2015 04:24 PM, Marc Kleine-Budde wrote:
>     > Hello bombilee,
>     >
>     > On 05/07/2015 04:20 PM, Marc Kleine-Budde wrote:
>     >> diff --git a/slcanpty.c b/slcanpty.c
>     >> index c062a027da41..f485ac775a53 100644
>     >> --- a/slcanpty.c
>     >> +++ b/slcanpty.c
>     >> @@ -185,6 +185,13 @@ rx_restart:
>     >>              ptr = 1;
>     >>              goto rx_out;
>     >>      }
>     >> +    /* check for 'v'ersion command */
>     >> +    if (cmd == 'v') {
>     >> +            sprintf(replybuf, "v1014\r");
>     >
>     > Is there a special meaning behing "v1014"? Where does the string come from?
> 
>     We *already* check for the version command!
> 
>     But it has to be 'V' with upper case:
> 
>     See http://www.can232.com/docs/can232_v3.pdf page 12:
> 
>     Get Version number of both CAN232 hardware and software
>     This command is only active always.
>     Example: V[CR]
>     Get Version numbers
>     Returns: V and a 2 bytes BCD value for hardware version and
>     a 2 byte BCD value for software version plus
>     CR (Ascii 13) for OK. E.g. V1013[CR]
> 
>     The SLCAN/Lawicel protocol is case sensitive!!
> 
>     See T/t R/r S/s M/m commands.
> 
>     A hunk could be to support lower case for the version information check too.
> 
>     But IMO that's the wrong approach.
> 
>     The application should send 'V' and not 'v' - and this should be fixed there.
> 
>     What kind of application sends 'v' to get the version information?
> 
>     Regards,
>     Oliver
> 
>     >
>     >> +            tmp = strlen(replybuf);
>     >> +            ptr = 1;
>     >> +            goto rx_out;
>     >> +    }
>     >>
>     >>      /* check for serial 'N'umber command */
>     >>      if (cmd == 'N') {
>     >>
>     >
>     > Marc
>     >
> 
>