Re: CAN implementation on A20 Allwinner

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]

On 08/27/2015 03:04 PM, Gerhard Bertelsmann wrote:
>> It it's sja1000 compatible, it should work out of the box with the
>> existing sja1000 device tree binding.
> 
> the Allwinner CAN IP is very similar but not exactly a SJA1000, e g. the
> registers differ and some are 32 bit wide and not 8 bit.

Which are the registers that have the upper 24 bit used?

> So the question is: change the sja1000 and the platform file for 
> "quirks" or write a new independent one ?

Depends on the actual differences, but I'd go for quirks first.

> Which way do you prefer or better: which driver will be accepted for 
> mainline ?

The github driver lacks a proper driver model binding, so that's not
mainline ready.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]