From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Daniel Squires <dan@engineeredarts.co.uk>,
Austin Schuh <austin@peloton-tech.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
linux-can@vger.kernel.org
Subject: Re: socket can receive order
Date: Thu, 17 Sep 2015 21:18:28 +0200 [thread overview]
Message-ID: <55FB1204.5090908@hartkopp.net> (raw)
In-Reply-To: <55F05AFE.8070203@engineeredarts.co.uk>
Hello Daniel,
On 09.09.2015 18:14, Daniel Squires wrote:
> The Hack seems to work, its been a short test of a half hour so far, but
> before it happened reliably after a few seconds.
>
>> On Tue, Sep 8, 2015 at 9:56 AM Oliver Hartkopp <socketcan@hartkopp.net> wrote:
>>>
>>> See http://marc.info/?l=linux-netdev&m=143689694125450&w=2
>>>
>>> If so, please try the 'hack' I suggested on the netdev ML if it fixes your
>>> problem. It might help for the discussion too.
In the referenced posting above I suggested to set
skb_set_hash(skb, dev->ifindex, PKT_HASH_TYPE_L2);
to create a interface specific hash for the socket buffer.
And then to enable the receive packet steering (RPS) with
echo f > /sys/class/net/can0/queues/rx-0/rps_cpus
To create a proper patch and description I evaluated some more skb_set_hash()
parameters and finally discovered that setting the skb hash seems to be
obsolete ... %-)
Can you confirm that
echo f > /sys/class/net/can0/queues/rx-0/rps_cpus
already fixes the out-of-order issue even without setting the skb hash?
If so we could give a general recommendation for multi-core CPU system users
to enable RPS for CAN interfaces by setting the specific sysfs entry.
Regards,
Oliver
next prev parent reply other threads:[~2015-09-17 19:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 9:42 socket can receive order Daniel Squires
2015-09-08 10:01 ` Marc Kleine-Budde
2015-09-08 10:41 ` Daniel Squires
2015-09-08 11:13 ` Marc Kleine-Budde
2015-09-08 11:17 ` Daniel Squires
2015-09-08 11:20 ` Marc Kleine-Budde
2015-09-08 11:37 ` Daniel Squires
2015-09-08 16:56 ` Oliver Hartkopp
2015-09-09 2:30 ` Austin Schuh
2015-09-09 3:10 ` Brian Silverman
2015-09-09 16:23 ` Oliver Hartkopp
2015-09-09 12:05 ` Daniel Squires
2015-09-09 16:14 ` Daniel Squires
2015-09-09 16:31 ` Oliver Hartkopp
2015-09-17 19:18 ` Oliver Hartkopp [this message]
2015-09-08 11:46 ` Wolfgang Grandegger
2015-09-08 11:49 ` Daniel Squires
2015-09-08 11:56 ` Marc Kleine-Budde
2015-09-10 2:29 ` Tom Evans
2015-09-10 8:08 ` Daniel Squires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FB1204.5090908@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=austin@peloton-tech.com \
--cc=dan@engineeredarts.co.uk \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).