linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Oliver Pajonk <oliver@pjnk.de>, Michael Luxen <mluxen@gmx.net>
Cc: linux-can@vger.kernel.org, linux-can-owner@vger.kernel.org
Subject: Re: can-isotp-modules
Date: Wed, 04 Nov 2015 11:06:17 +0100	[thread overview]
Message-ID: <5639D899.1090305@hartkopp.net> (raw)
In-Reply-To: <44220b4fed9da26bb9ba1b9c2ec885c4@pjnk.de>

Hi all,

Oliver is right! :-)

Instead of

1. git clone https://github.com/hartkopp/can-isotp-modules/
2. cd can-isotp-modules
3. make

just do

1. git clone https://github.com/hartkopp/can-isotp-modules/
2. cd can-isotp-modules/net/can
3. ./make_isotp.sh

which should create a can-isotp.ko module there.

When the PF_CAN infrastructure is loaded (modprobe can) an

	insmod ./can-isotp.ko

should make it.

Currently MAX_MSG_LENGTH is set to 8200 to be able to play with the new jumbo 
PDU length in ISO 15765-2:2015. For previous ISO versions MAX_MSG_LENGTH was 
set to 4095. N.B. take care for the isotp can-utils buffer length too when 
using jumbo PDU length there.

Regards,
Oliver

On 04.11.2015 07:59, Oliver Pajonk wrote:
>
> Hi Michael,
>
> I was struggeling to compile ISO-TP as well (on my Raspi), but then I found
> this script (it was mentioned in some other mailing list post):
>
> https://github.com/hartkopp/can-isotp-modules/blob/master/net/can/make_isotp.sh
>
> That worked just fine. Maybe it helps?
>
> Best regards,
> Oliver
>
> On 2015-11-03 23:29, Michael Luxen wrote:
>> Hello Oliver,
>>
>> today I've tried to install can-isotp-modules on my BeagleBone Black by
>>
>> 1. git clone https://github.com/hartkopp/can-isotp-modules/
>> 2. cd can-isotp-modules
>> 3. make
>>
>> The make process on my Debian Jessie 8.2 (uname -r: 4.1.6-ti-r16)
>> powered BBB ends up with:
>>
>> root@beaglebone:~/can-isotp-modules# make
>> make -C /lib/modules/4.1.6-ti-r16/build M=/root/can-isotp-modules
>> modules TOPDIR=/root/can-isotp-modules
>> make[1]: Entering directory '/usr/src/linux-headers-4.1.6-ti-r16'
>>   CC [M]  /root/can-isotp-modules/drivers/net/can/vcan.o
>> In file included from include/linux/module.h:17:0,
>>                  from /root/can-isotp-modules/drivers/net/can/vcan.c:44:
>> /root/can-isotp-modules/drivers/net/can/vcan.c: In function '__check_echo':
>> include/linux/moduleparam.h:377:61: warning: return from incompatible
>> pointer type
>>   static inline type __always_unused *__check_##name(void) { return(p); }
>>                                                              ^
>> include/linux/moduleparam.h:428:35: note: in expansion of macro '__param_check'
>>  #define param_check_bool(name, p) __param_check(name, p, bool)
>>                                    ^
>> include/linux/moduleparam.h:145:2: note: in expansion of macro
>> 'param_check_bool'
>>   param_check_##type(name, &(value));       \
>>   ^
>> include/linux/moduleparam.h:125:2: note: in expansion of macro
>> 'module_param_named'
>>   module_param_named(name, name, type, perm)
>>   ^
>> /root/can-isotp-modules/drivers/net/can/vcan.c:91:1: note: in
>> expansion of macro 'module_param'
>>  module_param(echo, bool, S_IRUGO);
>>  ^
>>   CC [M]  /root/can-isotp-modules/drivers/net/can/slcan.o
>> /root/can-isotp-modules/drivers/net/can/slcan.c:46:24: fatal error:
>> asm/system.h: No such file or directory
>>  #include <asm/system.h>
>>                         ^
>> compilation terminated.
>> scripts/Makefile.build:264: recipe for target
>> '/root/can-isotp-modules/drivers/net/can/slcan.o' failed
>> make[3]: *** [/root/can-isotp-modules/drivers/net/can/slcan.o] Error 1
>> scripts/Makefile.build:403: recipe for target
>> '/root/can-isotp-modules/drivers/net/can' failed
>> make[2]: *** [/root/can-isotp-modules/drivers/net/can] Error 2
>> Makefile:1384: recipe for target '_module_/root/can-isotp-modules' failed
>> make[1]: *** [_module_/root/can-isotp-modules] Error 2
>> make[1]: Leaving directory '/usr/src/linux-headers-4.1.6-ti-r16'
>> Makefile:42: recipe for target 'modules' failed
>> make: *** [modules] Error 2
>>
>>
>> Any idea/hint how to fix this issue?
>>
>> Regards
>> Michael
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-can" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-can" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-11-04 10:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03 22:29 can-isotp-modules Michael Luxen
2015-11-04  6:59 ` can-isotp-modules Oliver Pajonk
2015-11-04 10:06   ` Oliver Hartkopp [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-11-06  5:59 AW: can-isotp-modules Michael Luxen
2016-03-28  9:43 ` can-isotp-modules Patrick Menschel
2016-03-30 12:20   ` can-isotp-modules Oliver Hartkopp
2016-03-30 13:24     ` can-isotp-modules Patrick Menschel
2016-03-30 14:54       ` can-isotp-modules Oliver Hartkopp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5639D899.1090305@hartkopp.net \
    --to=socketcan@hartkopp.net \
    --cc=linux-can-owner@vger.kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=mluxen@gmx.net \
    --cc=oliver@pjnk.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).