Re: [PATCH] can-doc: Add missing semicolon to example

[Oliver Hartkopp <socketcan@hartkopp.net>]

On 09.11.2015 14:20, Marc Kleine-Budde wrote:
> On 11/09/2015 02:17 PM, Stefan Tatschner wrote:
>> The example code for CAN_BCM,
>>
>> 	connect(s, (struct sockaddr *)&addr, sizeof(addr))
>>
>> lacks a semicolon at the end of the line. This patch adds that
>> missing semicolon to ensure that the given code snippet actually
>> compiles.
>>
>> Signed-off-by: Stefan Tatschner <rumpelsepp@sevenbyte.org>
> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
>
> Jonathan, feel free to take the patch via your tree.
>
> regards,
> Marc
>

Hi Marc,

I was pretty disappointed that my last patch needed more than six weeks to 
emerge in Linus' merge window tree, where it needs additional three month 
until release. When this happens again, we'll have this doc fix in Linux 4.5 - 
for what reason?

I would suggest to send these kinds of doc fixes and enhancements together 
with other CAN fixes via Daves net tree without this needless delay.

Regards,
Oliver

>> ---
>>   Documentation/networking/can.txt | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/networking/can.txt b/Documentation/networking/can.txt
>> index 4636b94..05fd83b 100644
>> --- a/Documentation/networking/can.txt
>> +++ b/Documentation/networking/can.txt
>> @@ -681,7 +681,7 @@ solution for a couple of reasons:
>>       addr.can_family = AF_CAN;
>>       addr.can_ifindex = ifr.ifr_ifindex;
>>
>> -    connect(s, (struct sockaddr *)&addr, sizeof(addr))
>> +    connect(s, (struct sockaddr *)&addr, sizeof(addr));
>>
>>       (..)
>>
>>
>
>