linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Holger Schurig <holgerschurig@gmail.com>
Cc: linux-can@vger.kernel.org, kernel@pengutronix.de,
	bhupesh.sharma@freescale.com
Subject: Re: [PATCH v2 00/11] RFC: cleanup flexcan driver, introduce and make use of IRQ offloading
Date: Mon, 18 Jan 2016 23:04:48 +0100	[thread overview]
Message-ID: <569D6180.8030906@pengutronix.de> (raw)
In-Reply-To: <87egdf5eca.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1987 bytes --]

On 01/18/2016 12:14 PM, Holger Schurig wrote:
> Marc Kleine-Budde <mkl@pengutronix.de> writes:
> 
>> Testing and feedback welcome.
> 
> And here it is, albeit a bit late:
> 
> ------------[ cut here ]------------
> WARNING: CPU: 0 PID: 0 at /home/schurig/d/mkarm/linux-4.4/drivers/net/can/rx-fifo.c:203 can_rx_fifo_irq_offload+0x214/0x264()
> can_rx_fifo_irq_offload: No messages found, RX-FIFO out of sync?
> Modules linked in: bnep btusb btrtl btbcm btintel bluetooth smsc95xx usbnet mii imx_sdma flexcan dlog(O)
> CPU: 0 PID: 0 Comm: swapper/0 Tainted: G           O    4.4.0 #1
> Hardware name: Freescale i.MX6 Quad/DualLite (Device Tree)

Thanks for testing, this driver triggers what we think a hardware bug,
resulting in packages are not beeing filled into the correct order into
the hardware. There are some people at fsl/nxp looking into this issue
at the hardware level.

> flexcan/flexcan-calculate-default-value-for-imask1-during-runtime.patch
> flexcan/flexcan-make-TX-mailbox-selectable-during-runtime.patch
> flexcan/rx-fifo-Add-support-for-simple-irq-offloading.patch
> flexcan/flexcan-make-use-of-rx-fifos-irq_offload_simple.patch
> flexcan/flexcan-add-missing-register-definitions.patch
> flexcan/flexcan-activate-individual-RX-masking-and-initialize-reg_rximr.patch
> flexcan/flexcan-add-quirk-FLEXCAN_QUIRK_ENABLE_EACEN_RRS.patch
> flexcan/flexcan-reg_imask2_default.patch
> flexcan/rx-fifo-introduce-software-rx-fifo-implementation.patch
> flexcan/flexcan-add-support-for-rx-fifo-based-software-FIFO-implementation.patch
> flexcan/flexcan-switch-imx6-and-vf610-to-software-based-fifo.patch

You can omit the last patch and it should work.

regards,
Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

  reply	other threads:[~2016-01-18 22:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-10 12:33 [PATCH v2 00/11] RFC: cleanup flexcan driver, introduce and make use of IRQ offloading Marc Kleine-Budde
2015-12-10 12:33 ` [PATCH v2 01/11] can: flexcan: calculate default value for imask1 during runtime Marc Kleine-Budde
2015-12-10 12:33 ` [PATCH v2 02/11] can: flexcan: make TX mailbox selectable " Marc Kleine-Budde
2015-12-10 12:33 ` [PATCH v2 03/11] can: rx-fifo: Add support for simple irq offloading Marc Kleine-Budde
2015-12-10 12:33 ` [PATCH v2 04/11] can: flexcan: make use of rx-fifo's irq_offload_simple Marc Kleine-Budde
2015-12-10 12:33 ` [PATCH v2 05/11] can: flexcan: add missing register definitions Marc Kleine-Budde
2015-12-10 12:33 ` [PATCH v2 06/11] can: flexcan: activate individual RX masking and initialize reg_rximr Marc Kleine-Budde
2015-12-10 12:33 ` [PATCH v2 07/11] can: flexcan: add quirk FLEXCAN_QUIRK_ENABLE_EACEN_RRS Marc Kleine-Budde
2015-12-10 12:33 ` [PATCH v2 08/11] can: flexcan: reg_imask2_default Marc Kleine-Budde
2015-12-10 12:33 ` [PATCH v2 09/11] can: rx-fifo: introduce software rx-fifo implementation Marc Kleine-Budde
2015-12-10 12:33 ` [PATCH v2 10/11] can: flexcan: add support for rx-fifo based software FIFO implementation Marc Kleine-Budde
2015-12-10 12:33 ` [PATCH v2 11/11] can: flexcan: switch imx6 and vf610 to software based fifo Marc Kleine-Budde
     [not found] ` <CAOpc7mGK9WEnbowHJONbP-szW7mVQbU46uUPXF8V09omqWLQMA@mail.gmail.com>
2015-12-10 14:04   ` [PATCH v2 00/11] RFC: cleanup flexcan driver, introduce and make use of IRQ offloading Marc Kleine-Budde
2016-01-18 11:14 ` Holger Schurig
2016-01-18 22:04   ` Marc Kleine-Budde [this message]
2016-01-19  0:26     ` Tom Evans
2016-02-22 15:16       ` Mirza Krak
2016-02-22 15:19         ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569D6180.8030906@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=bhupesh.sharma@freescale.com \
    --cc=holgerschurig@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-can@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).