From: Stephane Grosjean <s.grosjean@peak-system.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can Mailing List <linux-can@vger.kernel.org>
Subject: Re: [PATCH] can/peak_pci: fix FPGA potential frame loss issue
Date: Wed, 20 Jan 2016 15:29:18 +0100 [thread overview]
Message-ID: <569F99BE.70001@peak-system.com> (raw)
In-Reply-To: <569F9588.2090809@pengutronix.de>
Le 20/01/2016 15:11, Marc Kleine-Budde a écrit :
> On 01/20/2016 12:15 PM, Stephane Grosjean wrote:
>> This patch installs a workaround when the driver detects one of the
>> following PEAK-System CAN interfaces, running a firmware < v1.3.0:
> Is the problem fixed on FW >= 1.3.0? Is it possible to update the
> firmware? If so, what about printing a warning message about known
> problem with the firmware?
Yes, problem is fixed with 1.3.0.
And yes, firmware can be updated.
What kind of warning message are you talking about? Do you mean that
peak_pci could dev_warn() a text msg to inform about the fact that the
current FW is able to be upgraded?
If yes, since peak_pci prints a single info line per CAN channel, what
would you prefer?
- the same warning about the old FW version, for each candev, something
like:
[ 2200.129168] peak_pci 0000:05:01.0: can0 at
reg_base=0xffffc90000678000 cfg_base=0xffffc90000676000 irq=22 FW=1.2.0
should be updated
[ 2200.129307] peak_pci 0000:05:01.0: can1 at
reg_base=0xffffc90000678400 cfg_base=0xffffc90000676000 irq=22 FW=1.2.0
should be updated
- or a single warning msg for the hardware device, something like:
[ 2200.129168] peak_pci 0000:05:01.0: Warning: FW v1.2.0 needs a
workaround; update is available
[ 2200.129168] peak_pci 0000:05:01.0: can0 at
reg_base=0xffffc90000678000 cfg_base=0xffffc90000676000 irq=22
[ 2200.129307] peak_pci 0000:05:01.0: can1 at
reg_base=0xffffc90000678400 cfg_base=0xffffc90000676000 irq=22
?
Stéphane
--
PEAK-System Technik GmbH
Sitz der Gesellschaft Darmstadt - HRB 9183
Geschaeftsfuehrung: A.Gach, U.Wilhelm
--
next prev parent reply other threads:[~2016-01-20 14:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 11:15 [PATCH] can/peak_pci: fix FPGA potential frame loss issue Stephane Grosjean
2016-01-20 14:11 ` Marc Kleine-Budde
2016-01-20 14:29 ` Stephane Grosjean [this message]
2016-01-20 14:33 ` Marc Kleine-Budde
2016-01-21 17:51 ` Oliver Hartkopp
2016-01-22 9:10 ` Stephane Grosjean
2016-04-08 5:36 ` Oliver Hartkopp
2016-01-20 14:51 ` Andri Yngvason
2016-02-23 16:53 ` Andri Yngvason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569F99BE.70001@peak-system.com \
--to=s.grosjean@peak-system.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).