From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Kleine-Budde Subject: Re: [RFC] [PATCH v3] can: fix handling of unmodifiable configuration options Date: Tue, 15 Mar 2016 10:22:38 +0100 Message-ID: <56E7D45E.8040404@pengutronix.de> References: <1457982490-27520-1-git-send-email-socketcan@hartkopp.net> <56E7C502.4080109@hartkopp.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="h3JRCLbBHXRJgUcRV0hREuvTdFFlK79L3" Return-path: Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:41402 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934342AbcCOJWw (ORCPT ); Tue, 15 Mar 2016 05:22:52 -0400 In-Reply-To: <56E7C502.4080109@hartkopp.net> Sender: linux-can-owner@vger.kernel.org List-ID: To: Oliver Hartkopp , Ramesh Shanmugasundaram , "linux-can@vger.kernel.org" , Stephane Grosjean This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --h3JRCLbBHXRJgUcRV0hREuvTdFFlK79L3 Content-Type: multipart/mixed; boundary="tiNxMGM2mtjTJBkjkF8LlsvXbX3dCD0rC" From: Marc Kleine-Budde To: Oliver Hartkopp , Ramesh Shanmugasundaram , "linux-can@vger.kernel.org" , Stephane Grosjean Message-ID: <56E7D45E.8040404@pengutronix.de> Subject: Re: [RFC] [PATCH v3] can: fix handling of unmodifiable configuration options References: <1457982490-27520-1-git-send-email-socketcan@hartkopp.net> <56E7C502.4080109@hartkopp.net> In-Reply-To: <56E7C502.4080109@hartkopp.net> --tiNxMGM2mtjTJBkjkF8LlsvXbX3dCD0rC Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/15/2016 09:17 AM, Oliver Hartkopp wrote: > Hello Marc, >=20 > On 03/15/2016 08:15 AM, Ramesh Shanmugasundaram wrote: >>> Oliver Hartkopp >>> Subject: [RFC] [PATCH v3] can: fix handling of unmodifiable configura= tion >>> options >=20 > (..) >=20 >>> Reported-by: Ramesh Shanmugasundaram >>> Signed-off-by: Oliver Hartkopp >> >> Reviewed-by: Ramesh Shanmugasundaram >> Tested-by: Ramesh Shanmugasundaram >> >=20 > I would suggest to queue this patch for stable 3.18+ where I applies=20 > without problems. Ok, I've added: Cc: # >=3D 3.18 > Ubuntu maintains a 3.16 longterm kernel - but I do not see a real=20 > benefit for that kernel as it would only affect the M_CAN driver there.= =20 > I doubt any M_CAN hardware is used together with this specific Ubuntu=20 > kernel as we already would have get any feedback then. >=20 > Once this patch emerged in Linux 4.0 I'll send a patch for the PCAN USB= =20 > FD adapters which are potential can_set_static_ctrlmode() users too. No need to wait, you can send the patches now. They'll go via can-next anyway. regards, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --tiNxMGM2mtjTJBkjkF8LlsvXbX3dCD0rC-- --h3JRCLbBHXRJgUcRV0hREuvTdFFlK79L3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCgAGBQJW59ReAAoJED07qiWsqSVq6VsH/3Fle8drQ+UlrAcn+XaLWEAN kDcWwP2YTPare6DN2BjuOwv82ZklAy8BGagVmbA6vA7H7UpYOeH3bfIbm7+izAnI tn4gN++4XuaXtCtrG7CI7WmnCBre2TITGHV1PSVv9n6xOLwgdoNxA1UEny90LPF2 BUUTHJeuEGBDUngmWjyUXTb98jk84I5+gzabSWGJIiJ1g2Hgv/UChoarxlrgVugr OofNlw6vawlVp80f9srUPoFxANY7KYZKdIYEONcq6eQhWODTDNg03RJMsTs1YWH2 5Kh0xqCJbUi7QtEPU3SKxZ6/isG/+At/qglHBZWocqLaD8B0vlO6Ikrit36ioQs= =caTu -----END PGP SIGNATURE----- --h3JRCLbBHXRJgUcRV0hREuvTdFFlK79L3--