From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Ico Doornekamp <ico@pruts.nl>
Cc: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Subject: Re: CAN libpcap capture endianess
Date: Wed, 11 May 2016 15:25:46 +0200 [thread overview]
Message-ID: <573332DA.7070400@hartkopp.net> (raw)
In-Reply-To: <1462969665-sup-623@pruts.nl>
On 05/11/2016 02:28 PM, Ico Doornekamp wrote:
> * On 2016-05-11 10:17:13 +0200, Oliver Hartkopp wrote:
>
>> That's strange indeed.
>>
>> Can you send the output of
>>
>> ip -details link show vcan0
>> ip -details link show slcan0
>
> $ ip -details link show vcan0
> 4: vcan0: <NOARP,UP,LOWER_UP> mtu 16 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1
> link/can promiscuity 0
> vcan
>
> $ ip -details link show slcan0
> 7: slcan0: <NOARP,UP,LOWER_UP> mtu 16 qdisc pfifo_fast state UNKNOWN mode DEFAULT group default qlen 10
> link/can promiscuity 0
>
When my posted patch does not have an effect it may be worth looking at
the differences of the selected qdiscs (noqueue/pfifo).
>> At least the CAN ID is 'AND'ed with CAN_ERR_MASK 0x1FFFFFFF :-)
>> That's the reason for the missing '2' due to CAN_ERR_FLAG.
>
> Indeed, I figured that much already.
>
>> Btw, can you check if this patch fixes the issue:
>
> This pach seems to be already in the 4.4.0 kernel, which I'm running.
Hm - no.
The patch I posted changes slcan.c - which the original patch did not touch.
The slcan.c patch is based on latest Linux 4.6.0-rc7-00055-gc511462 :-)
Please try it out.
Regards,
Oliver
next prev parent reply other threads:[~2016-05-11 13:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 17:42 CAN libpcap capture endianess Ico
2013-09-11 18:22 ` Marc Kleine-Budde
2013-09-11 18:30 ` Ico Doornekamp
2013-09-11 18:38 ` Marc Kleine-Budde
2013-09-11 18:53 ` Ico Doornekamp
2013-09-11 19:22 ` Oliver Hartkopp
2013-09-11 19:17 ` Oliver Hartkopp
2013-09-11 19:34 ` Marc Kleine-Budde
2013-09-11 19:37 ` Marc Kleine-Budde
2013-09-11 20:05 ` Ico Doornekamp
2013-09-11 20:11 ` Marc Kleine-Budde
2013-09-12 6:52 ` Ico Doornekamp
2013-09-12 8:00 ` Marc Kleine-Budde
2013-09-12 8:47 ` Ico Doornekamp
2013-09-12 8:52 ` Marc Kleine-Budde
2013-09-12 9:09 ` Ico Doornekamp
2013-09-12 9:13 ` Marc Kleine-Budde
2013-09-12 9:31 ` Ico Doornekamp
2016-05-10 19:25 ` Ico Doornekamp
2016-05-11 7:40 ` Oliver Hartkopp
[not found] ` <1462952665-sup-1016@pruts.nl>
2016-05-11 8:17 ` Oliver Hartkopp
2016-05-11 12:28 ` Ico Doornekamp
2016-05-11 13:25 ` Oliver Hartkopp [this message]
2016-05-11 17:01 ` Ico Doornekamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573332DA.7070400@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=ico@pruts.nl \
--cc=linux-can@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).