linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>,
	Mirza Krak <mirza.krak@hostmobility.com>
Cc: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	Wolfgang Grandegger <wg@grandegger.com>
Subject: Re: [RFC] K-Line protocol via SocketCAN
Date: Fri, 20 May 2016 13:59:31 +0200	[thread overview]
Message-ID: <573EFC23.2040906@denx.de> (raw)
In-Reply-To: <573EAE9D.20006@hartkopp.net>

On 05/20/2016 08:28 AM, Oliver Hartkopp wrote:
> Hi,

Hi!

> I removed Dave Miller from the discussion not to be tagged as SPAM :-)
> That's not Daves focus as networking maintainer ...

Heh, all right.

> Here's an update about the LIN Status from Pavel Pisa:
> 
> http://marc.info/?l=linux-can&m=146163127517268&w=2

I am aware of the sllin. There is also freediag , which implements kline
protocol.

> I remember a K-Line implementation for Linux where we had a MPC5200 UART
> which we programmed with bit-banging of some control line to do the
> 5bit/s opening pattern.
> After that we went to 10400 bit/s and did some K-Line communication.
> All this was done by a user space application on /dev/ttyS0.

Yes, and this does make perfect sense until you start dealing with
faster modes and need more precise timing. The K-Line is limited by
250kBaud/s bus speed.

> What would be the advantages to put this into kernel space (or into the
> CAN networking infrastructure)?

I see two for putting this into the kernel:
- At faster bus speeds, you can achieve more precise timing if this is
  in the kernel, both of the inter-byte delay and also for the
  timestamps. Having this in the kernel even allows usage of the
  realtime extensions if needed.
- Dedicated hardware driver can plug into such K-Line infrastructure.
  Such hardware might be needed to support the faster modes to further
  increase the timing precision.

And two for using socketcan/network interface:
- The addressing support of the network stack can be mapped to K-Line
  bus addresses.
- The rtnl can be used as an extensible interface for configuring the
  K-Line parameters.

Cheers!

> Regards,
> Oliver
> 
> 
> On 05/20/2016 08:04 AM, Mirza Krak wrote:
>> 2016-05-20 1:15 GMT+02:00 Marek Vasut <marex@denx.de>:
>>> I will also need to add support for the LIN protocol and SENT protocol
>>> further down the line. I will also likely revisit the Arinc at some
>>> point afterward. So I would like to know how to deal with this protocol
>>> mess.
>>
>> FYI, there has been a similar LIN project for quite a while [1]. You
>> might have seen it earlier?
>>
>> [1]. http://rtime.felk.cvut.cz/gitweb/linux-lin.git
>>


-- 
Best regards,
Marek Vasut

  reply	other threads:[~2016-05-20 11:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-19 23:15 [RFC] K-Line protocol via SocketCAN Marek Vasut
2016-05-20  6:04 ` Mirza Krak
2016-05-20  6:28   ` Oliver Hartkopp
2016-05-20 11:59     ` Marek Vasut [this message]
2016-05-22 20:27       ` Patrick Menschel
2016-05-22 21:11         ` Marek Vasut
2016-06-01  2:26       ` Marek Vasut
2016-06-05 12:07         ` Oliver Hartkopp
2016-06-09 15:00           ` Marek Vasut
2016-06-09 18:29             ` Oliver Hartkopp
2016-06-09 19:21               ` Marek Vasut
2016-06-09 20:12                 ` Oliver Hartkopp
2016-06-11 19:42                   ` Marek Vasut
2016-06-12 19:28                     ` Oliver Hartkopp
2016-06-13 22:07                       ` Marek Vasut
2016-06-14  6:10                         ` Oliver Hartkopp
2016-06-15  3:42                           ` Marek Vasut
2016-06-15  6:57                             ` Oliver Hartkopp
2016-06-15 11:05                               ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=573EFC23.2040906@denx.de \
    --to=marex@denx.de \
    --cc=linux-can@vger.kernel.org \
    --cc=mirza.krak@hostmobility.com \
    --cc=mkl@pengutronix.de \
    --cc=socketcan@hartkopp.net \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).