From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Ed Spiridonov <edo.rus@gmail.com>,
Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org
Subject: Re: [PATCH] can: mcp251x: add some messages to mcp251x_can_probe()
Date: Sat, 18 Jun 2016 10:41:40 +0200 [thread overview]
Message-ID: <57650944.5090509@hartkopp.net> (raw)
In-Reply-To: <CACm0Nn3L0fqtRMNJCJrPhnrM0JRaEn+g=3i5CSMvRLkKEAjkJQ@mail.gmail.com>
Hello Marc,
On 06/17/2016 10:41 PM, Ed Spiridonov wrote:
> 17.06.2016 12:22 пользователь "Marc Kleine-Budde" <mkl@pengutronix.de> написал:
>>
>>> @@ -1156,6 +1158,8 @@ static int mcp251x_can_probe(struct spi_device *spi)
>>>
>>> devm_can_led_init(net);
>>>
>>> + netdev_info(net, "successfully initialized.\n");
>>
>> I'll remove this hunk, as we try to make the CAN devices as silent as
>> possible in case of no errors.
I agree with Ed in this special case.
In opposite to CAN interfaces that reside on local busses or inside of
SoCs the mcp251x is attached indirectly via SPI. This adds additional
options to fail at initialization time.
As USB interfaces also tell about the USB plug-in and about their
successful netdev initialization - the SPI based interfaces should be
able to do it similarly.
Even the mcp251x stuff is not a very high performance CAN interface
implementation many RasPi users do their first steps with SocketCAN
using this tricky hardware setup.
That's why I vote for more information at initialization time too.
Regards,
Oliver
>
>
> Why it is so important to be totally silent? IMHO one line per CAN bus
> isn't too much.
> But it could help to debug new configuration, e.g. to find wrong
> device tree configuration, especially with several CAN buses.
>
> I made this patch because a lot of complains on Raspberry PI forum.
> Current module does not produce any message if module initializes
> MCP2510/2515 chip successfully or not. It could be confusing.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-can" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-06-18 8:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-29 1:59 [PATCH] can: mcp251x: add some messages to mcp251x_can_probe() Ed Spiridonov
2016-06-17 9:22 ` Marc Kleine-Budde
2016-06-17 20:41 ` Ed Spiridonov
2016-06-18 8:41 ` Oliver Hartkopp [this message]
[not found] ` <CACm0Nn320ry07YOuorrMO=u8Q4+JsOd9i3s7eFAwQ-L8AWGm=Q@mail.gmail.com>
2016-06-20 8:47 ` Marc Kleine-Budde
2016-06-20 18:49 ` Ed Spiridonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57650944.5090509@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=edo.rus@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).