[PATCH] selftests: can: enable CONFIG_CAN_VCAN as a module

[PATCH] selftests: can: enable CONFIG_CAN_VCAN as a module

[Davide Caratti]

a proper kernel configuration for running kselftest can be obtained with:

 $ yes | make kselftest-merge

Build of 'vcan' driver is currently missing, while the other required knobs
are already there because of net/link_netns.py [1]. Add a config file in
selftests/net/can the store the minimum set of kconfig needed for CAN
selftests.

[1] https://patch.msgid.link/20250219125039.18024-14-shaw.leon@gmail.com

Fixes: 77442ffa83e8 ("selftests: can: Import tst-filter from can-tests")
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
---
 tools/testing/selftests/net/can/config | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 tools/testing/selftests/net/can/config

diff --git a/tools/testing/selftests/net/can/config b/tools/testing/selftests/net/can/config
new file mode 100644
index 000000000000..11a02b0a0c6a
--- /dev/null
+++ b/tools/testing/selftests/net/can/config
@@ -0,0 +1,5 @@
+CONFIG_CAN=m
+CONFIG_CAN_RAW=m
+CONFIG_CAN_DEV=m
+CONFIG_CAN_NETLINK=y
+CONFIG_CAN_VCAN=m
-- 
2.47.0

Re: [PATCH] selftests: can: enable CONFIG_CAN_VCAN as a module

[Vincent Mailhol]

Hi David,

Thanks for the patch!

On 8/16/25 1:54 AM, Davide Caratti wrote:
> a proper kernel configuration for running kselftest can be obtained with:
> 
>  $ yes | make kselftest-merge
> 
> Build of 'vcan' driver is currently missing, while the other required knobs
> are already there because of net/link_netns.py [1]. Add a config file in
> selftests/net/can the store the minimum set of kconfig needed for CAN
> selftests.
> 
> [1] https://patch.msgid.link/20250219125039.18024-14-shaw.leon@gmail.com
> 
> Fixes: 77442ffa83e8 ("selftests: can: Import tst-filter from can-tests")
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>
> ---
>  tools/testing/selftests/net/can/config | 5 +++++
>  1 file changed, 5 insertions(+)
>  create mode 100644 tools/testing/selftests/net/can/config
> 
> diff --git a/tools/testing/selftests/net/can/config b/tools/testing/selftests/net/can/config
> new file mode 100644
> index 000000000000..11a02b0a0c6a
> --- /dev/null
> +++ b/tools/testing/selftests/net/can/config
> @@ -0,0 +1,5 @@
> +CONFIG_CAN=m
> +CONFIG_CAN_RAW=m
> +CONFIG_CAN_DEV=m
> +CONFIG_CAN_NETLINK=y
> +CONFIG_CAN_VCAN=m

Some of those config symbols are already present in the config file of the
parent directory:

  $ grep CAN tools/testing/selftests/net/config
  CONFIG_CAN=m
  CONFIG_CAN_DEV=m
  CONFIG_CAN_VXCAN=m

Maybe you can remove the now redundant config symbols from net/config and
consolidate everything under net/can/config?


Yours sincerely,
Vincent Mailhol