Re: Associate physical device with device name

["André Hartmann" <aha_1980@gmx.de>]

Hi Oliver,

Am 09.02.2018 um 18:09 schrieb Oliver Hartkopp:
> 
> 
> On 02/09/2018 04:35 PM, Jimmy Assarsson wrote:
>> On 2018-02-09 14:24, Marc Kleine-Budde wrote:
>>> On 02/09/2018 12:21 PM, Jimmy Assarsson wrote:
>>>> All devices with the same EAN look identical, since we do not set 
>>>> serial
>>>> number in the USB descriptor.
>>>
>>> That should be done on the next FW revision.
>>
>> It is left out on purpose. I don't remember the details, but it had
>> something to do with Windows reinstalling the driver whenever a device
>> with different serial number is connected to the same USB port.
>>
>>> Ok - I see two possibilities.
>>>
>>> 1) sysfs file
>>> Add a file to sysfs that contains the serial number, see:
>>> http://lxr.bootlin.com/linux/latest/source/drivers/net/can/softing/softing_main.c#L718 
>>>
>>>
>>> 2) ethtool eeprom
>>> You can export the serial number via ethtool's dump eeprom 
>>> functionality.
>>>
>>> Better try 1).
>>
>> Great :) Will try this next week.
> 
> Would it make sense to provide a common sysfs infrastructure in
> 
>      linux/drivers/net/can/dev.c
> 
> to populate
> 
>      /sys/class/net/<can-interface-name>/<serial-num-whatever>
> 
> instead of maintaining this stuff in each single driver?
> 
> We have this requirement in the softing/kvaser/peak adapters so far.
> 
> We could provide some pointer in struct can_priv which points to a 
> struct which contains the sysfs content - or something like this.

+1. A general solution to read a serial number from sysfs would be very 
welcome.

> Any thoughts?
> 
> Best,
> Oliver
> 
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-can" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html