linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org, kernel@pengutronix.de, kurt.van.dijck@eia.be
Subject: Re: [PATCH v5 1/2] can: sja1000: fix "irq X: nobody cared" problem
Date: Mon, 25 Nov 2013 08:57:17 +0100	[thread overview]
Message-ID: <808341cbce15240bc45f49ba76ae168b@grandegger.com> (raw)
In-Reply-To: <1385329501-28021-1-git-send-email-mkl@pengutronix.de>

Hi Marc,



On Sun, 24 Nov 2013 22:44:59 +0100, Marc Kleine-Budde <mkl@pengutronix.de>

wrote:

> Hello,

> 

> as Kurt suggested I've split up the patch into two parts. I've

added/keept

> Wolfgang's Acks at both parts, hope that's okay. Further I've added to

the

> description of the first patch, that it fixes the "irq X: nobody cared".

Is

> this corrrect? If I understand the discussion and code correct, the

second

> patch is only relevant in the hot unplug case.



It was Austin Schuh who reported a problem with -rt, which do not show up

with

vanilla Linux. See thread with the subject "sja1000 interrupt problem".

It's

still unclear what the real cause of this problem is. Anyway, Oliver and

myself

looked into the SJA1000 code and realized some inconsistencies with the

interrupt acknowledgement via "post_irq" callback. Oliver already

clarified

that.



Wolfgang.

      parent reply	other threads:[~2013-11-25  7:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-24 21:44 [PATCH v5 1/2] can: sja1000: fix "irq X: nobody cared" problem Marc Kleine-Budde
2013-11-24 21:45 ` [PATCH v5 1/2] can: sja1000: fix pre_irq() and post_irq() handling Marc Kleine-Budde
2013-11-24 21:45 ` [PATCH v5 2/2] can: sja1000: fix return value of interrupt handler Marc Kleine-Budde
2013-11-24 22:38   ` Oliver Hartkopp
2013-11-24 22:44     ` Marc Kleine-Budde
2013-11-25  7:57 ` Wolfgang Grandegger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=808341cbce15240bc45f49ba76ae168b@grandegger.com \
    --to=wg@grandegger.com \
    --cc=kernel@pengutronix.de \
    --cc=kurt.van.dijck@eia.be \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).