From: Alexander Stein <alexander.stein@systec-electronic.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
linux-can@vger.kernel.org
Subject: Re: [PATCH] can: c_can: Fix bit clearing and message object read
Date: Tue, 08 Apr 2014 16:24:43 +0200 [thread overview]
Message-ID: <8083460.0p0S3IB599@ws-stein> (raw)
In-Reply-To: <alpine.DEB.2.02.1404081613141.14882@ionos.tec.linutronix.de>
On Tuesday 08 April 2014 16:15:37, Thomas Gleixner wrote:
> On Tue, 8 Apr 2014, Alexander Stein wrote:
> > On Tuesday 08 April 2014 15:07:10, Thomas Gleixner wrote:
> > The problem is that NEWDAT in the crtl register readout is most of the time set, but sometimes not.
> > Adding the delay above it is unset all the time :(
>
> Now what happens if you disable interrupts across the writes:
>
> local_irq_disable()
> write(COMMSK)
> write(COMREQ)
> local_irq_enable()
There are still message objects where NEWDAT is unset. Even if the c_can_msg_obj_is_busy check is included.
Regards,
Alexander
--
Dipl.-Inf. Alexander Stein
SYS TEC electronic GmbH
Am Windrad 2
08468 Heinsdorfergrund
Tel.: 03765 38600-1156
Fax: 03765 38600-4100
Email: alexander.stein@systec-electronic.com
Website: www.systec-electronic.com
Managing Director: Dipl.-Phys. Siegmar Schmidt
Commercial registry: Amtsgericht Chemnitz, HRB 28082
next prev parent reply other threads:[~2014-04-08 14:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 9:46 [PATCH] can: c_can: Fix bit clearing and message object read Alexander Stein
2014-04-08 13:07 ` Thomas Gleixner
2014-04-08 14:02 ` Alexander Stein
2014-04-08 14:15 ` Thomas Gleixner
2014-04-08 14:24 ` Alexander Stein [this message]
2014-04-09 0:42 ` Thomas Gleixner
2014-04-09 7:40 ` Alexander Stein
2014-04-09 10:28 ` Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8083460.0p0S3IB599@ws-stein \
--to=alexander.stein@systec-electronic.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=tglx@linutronix.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).