Re: About adding a new CAN-FD driver...

[Stephane Grosjean <s.grosjean@peak-system.com>]

Hello Oliver,

> linux/include/linux/can/ip-core/ 
++

Regards,
Stéphane

Le 17/11/2016 à 21:20, Oliver Hartkopp a écrit :
> Hi Stephane,
>
> On 11/17/2016 11:22 AM, Stephane Grosjean wrote:
>> I'm almost ready for pushing the stuff about CAN-FD over our PCIe boards
>> but I'm back to you before, because in one of your previous email, you
>> talked about "linux/include/linux/can/dev" directory as the better place
>> to put a common header file for all of our CAN-FD interfaces.
>>
>> AFAIK this directory does not exist so far... Did you actually mean
>> "linux/include/linux/can"? Or did you expect me to create the "dev"
>> subdir with pushing the corresponding patch?
>
> Yes. The latter.
>
> I think putting controller specific include files directly into 
> "linux/include/linux/can" is wrong in the way that the platform 
> specific content has a separate directory too.
>
> My initial suggestion was
>
> linux/include/linux/can/dev/
>
> but we may also think of
>
> linux/include/linux/can/controller/
> linux/include/linux/can/ctrl/
> linux/include/linux/can/ip-core/
> linux/include/linux/can/ctrl-core/
> linux/include/linux/can/can-core/
>
> 'ip-core' seems a good name too as it reflects the CAN controller 
> specific characteristics (e.g. memory register layout).
>
> What would you suggest as directory name?
>
> Regards,
> Oliver
>

--
PEAK-System Technik GmbH
Sitz der Gesellschaft Darmstadt - HRB 9183 
Geschaeftsfuehrung: A.Gach, U.Wilhelm
--