From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sean Nyekjaer <sean@geanix.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-can@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH can-next v2] dt-bindings: can: tcan4x5x: add missing required clock-names
Date: Thu, 28 Nov 2024 08:31:41 +0100 [thread overview]
Message-ID: <87378b2f-80a0-4a35-9989-9b96910701e3@kernel.org> (raw)
In-Reply-To: <20241128-tcancclk-v2-1-fbf07f1f1626@geanix.com>
On 28/11/2024 08:09, Sean Nyekjaer wrote:
> tcan4x5x requires an external clock called cclk, add it here.
Nothing improved. Device already has this clock, so your rationale is
not correct.
Also, offending patch is not in the next for some reason, so it should
be squashed there. Conversion which leads to incorrect binding is not a
correct conversion.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-11-28 7:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 7:09 [PATCH can-next v2] dt-bindings: can: tcan4x5x: add missing required clock-names Sean Nyekjaer
2024-11-28 7:31 ` Krzysztof Kozlowski [this message]
2024-11-28 7:49 ` Sean Nyekjaer
2024-11-28 8:09 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87378b2f-80a0-4a35-9989-9b96910701e3@kernel.org \
--to=krzk@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=sean@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox