From: Richard Palethorpe <rpalethorpe@suse.de>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Cyril Hrubis <chrubis@suse.cz>,
ltp@lists.linux.it, Oliver Hartkopp <socketcan@hartkopp.net>,
linux-can@vger.kernel.org
Subject: Re: [LTP] [PATCH v2 4/6] can_recv_own_msgs: Convert to new library
Date: Tue, 19 Jan 2021 16:34:14 +0000 [thread overview]
Message-ID: <87bldkq41l.fsf@suse.de> (raw)
In-Reply-To: <3277a88e-0301-7f3d-b024-c728e1041092@pengutronix.de>
Hello All,
Marc Kleine-Budde <mkl@pengutronix.de> writes:
> On 1/19/21 4:06 PM, Cyril Hrubis wrote:
>> Hi!
>>>> /*
>>>> - * tst-rcv-own-msgs.c
>>>> - *
>>>> - * Copyright (c) 2010 Volkswagen Group Electronic Research
>>>> - * All rights reserved.
>>>> - *
>>>> - * Redistribution and use in source and binary forms, with or without
>>>> - * modification, are permitted provided that the following conditions
>>>> - * are met:
>>>> - * 1. Redistributions of source code must retain the above copyright
>>>> - * notice, this list of conditions and the following disclaimer.
>>>> - * 2. Redistributions in binary form must reproduce the above copyright
>>>> - * notice, this list of conditions and the following disclaimer in the
>>>> - * documentation and/or other materials provided with the distribution.
>>>> - * 3. Neither the name of Volkswagen nor the names of its contributors
>>>> - * may be used to endorse or promote products derived from this software
>>>> - * without specific prior written permission.
>>>
>>> IANAL, I think you're missing this license. Is looks like some sort
>>> of BSD to me.
Ufff, thanks, I should pay more attention when it is a test imported
from elsewhere.
>>>
>>>> - *
>>>> - * Alternatively, provided that this notice is retained in full, this
>>>> - * software may be distributed under the terms of the GNU General
>>>> - * Public License ("GPL") version 2, in which case the provisions of the
>>>> - * GPL apply INSTEAD OF those given above.
>>>
>>> It doesn't say "or later".
>>
>> Looks like we cannot just remove this license. So what about moving this
>> text into a separate COPYING file and changing the SPDX to GPL-v2.0?
>
> This file is dual licensed, better keep it dual licensed.
>
> regards,
> Marc
HHmm, this appears to be the BSD-3-Clause license with the following
text inserted in the middle:
* Alternatively, provided that this notice is retained in full, this
* software may be distributed under the terms of the GNU General
* Public License ("GPL") version 2, in which case the provisions of the
* GPL apply INSTEAD OF those given above.
*
* The provided data structures and external interfaces from this code
* are not restricted to be used by modules with a GPL compatible license.
I don't see any corresponding SPDX identifier or exception for this. It
is probably easiest and safest just to keep it as-is.
--
Thank you,
Richard.
next prev parent reply other threads:[~2021-01-19 18:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 9:31 [PATCH v2 0/6] Convert CAN tests to new LTP API Richard Palethorpe
2021-01-19 9:31 ` [PATCH v2 1/6] API: Add FILE_SCANF to new lib Richard Palethorpe
2021-01-19 9:31 ` [PATCH v2 2/6] can: Add can_common.h for vcan device setup Richard Palethorpe
2021-01-19 18:05 ` [LTP] " Petr Vorel
2021-01-19 9:31 ` [PATCH v2 3/6] can_filter: Convert to new library Richard Palethorpe
2021-01-19 9:31 ` [PATCH v2 4/6] can_recv_own_msgs: " Richard Palethorpe
2021-01-19 14:53 ` Marc Kleine-Budde
2021-01-19 15:06 ` [LTP] " Cyril Hrubis
2021-01-19 15:09 ` Marc Kleine-Budde
2021-01-19 16:34 ` Richard Palethorpe [this message]
2021-01-19 16:39 ` Marc Kleine-Budde
2021-01-19 21:34 ` Oliver Hartkopp
2021-01-19 9:31 ` [PATCH v2 5/6] can: Remove obsolete test wrapper script Richard Palethorpe
2021-01-19 9:31 ` [PATCH v2 6/6] can: Update contact details Richard Palethorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bldkq41l.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=chrubis@suse.cz \
--cc=linux-can@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=mkl@pengutronix.de \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).