From: stephane.grosjean@free.fr
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: "linux-can Mailing List" <linux-can@vger.kernel.org>,
"Stéphane Grosjean" <stephane.grosjean@hms-networks.com>
Subject: Re: [PATCH] can: peak_usb: fix shift-out-of-bounds issue for 32-bit architectures
Date: Fri, 26 Sep 2025 09:26:45 +0200 (CEST) [thread overview]
Message-ID: <887285384.434276594.1758871605629.JavaMail.root@zimbra65-e11.priv.proxad.net> (raw)
In-Reply-To: <20250919-witty-bustard-of-certainty-29de42-mkl@pengutronix.de>
Hello Marc,
The reason is that delta_ts is still declared u32.
The problem came from my patch, where it was already declared as u64.
Sorry for that. I push a v2 asap.
----- Mail original -----
De: "Marc Kleine-Budde" <mkl@pengutronix.de>
À: "Stéphane Grosjean" <stephane.grosjean@free.fr>
Cc: "linux-can Mailing List" <linux-can@vger.kernel.org>, "Stéphane Grosjean" <stephane.grosjean@hms-networks.com>
Envoyé: Vendredi 19 Septembre 2025 19:18:15
Objet: Re: [PATCH] can: peak_usb: fix shift-out-of-bounds issue for 32-bit architectures
On 18.09.2025 15:23:57, Stéphane Grosjean wrote:
> From: Stéphane Grosjean <stephane.grosjean@hms-networks.com>
>
> Explicitly uses a 64-bit constant when the number of bits used for its
> shifting is 32 (which is the case for PC CAN FD interfaces supported by
> this driver).
>
> Signed-off-by: Stéphane Grosjean <stephane.grosjean@hms-networks.com>
This problem is not limited to 32-bit architectures, so I've removed
this from the subject.
I don't know why, but the patch didn't apply to net/main, applied
manually, but removed the line break.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
prev parent reply other threads:[~2025-09-26 7:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 13:23 [PATCH] can: peak_usb: fix shift-out-of-bounds issue for 32-bit architectures Stéphane Grosjean
2025-09-19 17:18 ` Marc Kleine-Budde
2025-09-26 7:26 ` stephane.grosjean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=887285384.434276594.1758871605629.JavaMail.root@zimbra65-e11.priv.proxad.net \
--to=stephane.grosjean@free.fr \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=stephane.grosjean@hms-networks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).