From mboxrd@z Thu Jan 1 00:00:00 1970 From: Franklin S Cooper Jr Subject: Re: [PATCH v2 3/4] can: m_can: Update documentation to mention new fixed transceiver binding Date: Wed, 9 Aug 2017 20:02:16 -0500 Message-ID: <93b31baa-c757-ddb7-a633-e04e931ae907@ti.com> References: <20170724230521.1436-1-fcooper@ti.com> <20170724230521.1436-4-fcooper@ti.com> <20170803170735.qntnxpx5olghzmbu@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from lelnx193.ext.ti.com ([198.47.27.77]:24092 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752510AbdHJBDC (ORCPT ); Wed, 9 Aug 2017 21:03:02 -0400 In-Reply-To: <20170803170735.qntnxpx5olghzmbu@rob-hp-laptop> Content-Language: en-US Sender: linux-can-owner@vger.kernel.org List-ID: To: Rob Herring Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-can@vger.kernel.org, wg@grandegger.com, mkl@pengutronix.de, quentin.schulz@free-electrons.com, dev.kurt@vandijck-laurijssen.be, andrew@lunn.ch, sergei.shtylyov@cogentembedded.com, socketcan@hartkopp.net Hi Rob, On 08/03/2017 12:07 PM, Rob Herring wrote: > On Mon, Jul 24, 2017 at 06:05:20PM -0500, Franklin S Cooper Jr wrote: >> Add information regarding fixed transceiver binding. This is especially >> important for MCAN since the IP allows CAN FD mode to run significantly >> faster than what most transceivers are capable of. >> >> Signed-off-by: Franklin S Cooper Jr >> --- >> Version 2 changes: >> Drop unit address >> >> Documentation/devicetree/bindings/net/can/m_can.txt | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/can/m_can.txt b/Documentation/devicetree/bindings/net/can/m_can.txt >> index 9e33177..e4abd2c 100644 >> --- a/Documentation/devicetree/bindings/net/can/m_can.txt >> +++ b/Documentation/devicetree/bindings/net/can/m_can.txt >> @@ -43,6 +43,11 @@ Required properties: >> Please refer to 2.4.1 Message RAM Configuration in >> Bosch M_CAN user manual for details. >> >> +Optional properties: >> +- fixed-transceiver : Fixed-transceiver subnode describing maximum speed > > This is a node, not a property. Sub nodes should have their own section. Fixed in my v4 that I just sent. > >> + that can be used for CAN and/or CAN-FD modes. See >> + Documentation/devicetree/bindings/net/can/fixed-transceiver.txt >> + for details. >> Example: >> SoC dtsi: >> m_can1: can@020e8000 { >> @@ -64,4 +69,9 @@ Board dts: >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_m_can1>; >> status = "enabled"; >> + >> + fixed-transceiver { >> + max-arbitration-speed = <1000000>; >> + max-data-speed = <5000000>; >> + }; >> }; >> -- >> 2.10.0 >>