From: Max Staudt <max@enpas.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>, Baul Lee <baul.lee@xbow.com>
Cc: mailhol@kernel.org, linux-can@vger.kernel.org,
linux-kernel@vger.kernel.org, federico.kirschbaum@xbow.com
Subject: Re: [PATCH net] can: can327: Fix stack out-of-bounds write in can327_handle_prompt()
Date: Wed, 19 Aug 2026 17:16:29 +0900 [thread overview]
Message-ID: <95f34c69-39b2-4e0a-83ce-ba7fdf5b7211@enpas.org> (raw)
In-Reply-To: <20260819-unbiased-impossible-foxhound-c525da-mkl@pengutronix.de>
On 8/19/26 3:23 PM, Marc Kleine-Budde wrote:
> On 19.08.2026 14:42:01, Baul Lee wrote:
>> can327_handle_prompt() hexdumps the frame queued for transmission, two
>> hex characters per payload byte, into an 18-byte on-stack buffer sized
>> for a classical 8-byte payload. The loop runs frame->len times without a
>> clamp, and frame is a struct can_frame copied verbatim from the skb
>> passed to can327_netdev_start_xmit().
>>
>> A CAN XL frame aliases struct can_frame such that canxl_frame.flags,
>
> I've a patch pending, that drops CAN_XL frames on non CAN_XL interfaces:
>
> https://lore.kernel.org/all/20260731-drop_canxl_frames-v1-1-7387b70353b3@kernel.org/
>
> So I think this patch is not needed.
Agreed, thanks!
Just in case you decide to take Baul's patch anyway, here is my
Reviewed-by: Max Staudt <max@enpas.org>
prev parent reply other threads:[~2026-08-19 8:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 5:42 [PATCH net] can: can327: Fix stack out-of-bounds write in can327_handle_prompt() Baul Lee
2026-08-19 6:05 ` sashiko-bot
2026-08-19 6:23 ` Marc Kleine-Budde
2026-08-19 8:16 ` Max Staudt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95f34c69-39b2-4e0a-83ce-ba7fdf5b7211@enpas.org \
--to=max@enpas.org \
--cc=baul.lee@xbow.com \
--cc=federico.kirschbaum@xbow.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox