Re: [PATCH v2] selftests: can: enable CONFIG_CAN_VCAN as a module

[Vincent Mailhol <mailhol@kernel.org>]

On 02/09/2025 at 01:07, Davide Caratti wrote:
> A proper kernel configuration for running kselftest can be obtained with:
> 
>  $ yes | make kselftest-merge
> 
> Build of 'vcan' driver is currently missing, while the other required knobs
> are already there because of net/link_netns.py [1]. Add a config file in
> selftests/net/can to store the minimum set of kconfig needed for CAN
> selftests. While at it, move existing CAN-related knobs from selftests/net
> to selftests/net/can.
> 
> [1] https://patch.msgid.link/20250219125039.18024-14-shaw.leon@gmail.com
> 
> V2:
>  - move CAN-related knobs needed by [1] into selftests/net/can (thanks
>    Vincent Mailhol); remove enabling of CAN_RAW and CAN_NETLINK since
>    Kconfig already implies them
> 
> Fixes: 77442ffa83e8 ("selftests: can: Import tst-filter from can-tests")
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>
> ---
>  tools/testing/selftests/net/can/config | 4 ++++
>  tools/testing/selftests/net/config     | 3 ---
>  2 files changed, 4 insertions(+), 3 deletions(-)
>  create mode 100644 tools/testing/selftests/net/can/config
> 
> diff --git a/tools/testing/selftests/net/can/config b/tools/testing/selftests/net/can/config
> new file mode 100644
> index 000000000000..0cb5598eb702
> --- /dev/null
> +++ b/tools/testing/selftests/net/can/config
> @@ -0,0 +1,4 @@
> +CONFIG_CAN=m
> +CONFIG_CAN_DEV=m
> +CONFIG_CAN_VXCAN=m
> +CONFIG_CAN_VCAN=m

One more nitpick: can you also sort the line in alphabetic order?

  CONFIG_CAN=m
  CONFIG_CAN_DEV=m
  CONFIG_CAN_VCAN=m
  CONFIG_CAN_VXCAN=m

(VXCAN after VCAN)

> diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config
> index c24417d0047b..18bec89c77b9 100644
> --- a/tools/testing/selftests/net/config
> +++ b/tools/testing/selftests/net/config
> @@ -120,9 +120,6 @@ CONFIG_XFRM_USER=m
>  CONFIG_IP_NF_MATCH_RPFILTER=m
>  CONFIG_IP6_NF_MATCH_RPFILTER=m
>  CONFIG_IPVLAN=m
> -CONFIG_CAN=m
> -CONFIG_CAN_DEV=m
> -CONFIG_CAN_VXCAN=m
>  CONFIG_NETKIT=y
>  CONFIG_NET_PKTGEN=m
>  CONFIG_IPV6_ILA=m

Yours sincerely,
Vincent Mailhol